D26866: [Kickoff] Theme separators

2020-01-23 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:33b138893bcd: [Kickoff] Theme separators (authored by 
filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26866?vs=74221=74263

REVISION DETAIL
  https://phabricator.kde.org/D26866

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf, #plasma, #vdg, davidedmundson, ngraham
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

2020-01-23 Thread Nathaniel Graham 
ngraham added a comment.


  No objection.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson, ngraham
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

2020-01-23 Thread Filip Fila 
filipf added a comment.


  Can I land it on the 5.18 branch as well?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson, ngraham
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

2020-01-23 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Makes sense now. Let's land this and then fix the separator in another patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson, ngraham
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

2020-01-23 Thread Filip Fila 
filipf added a subscriber: ndavis.
filipf added a comment.


  Might actually be a lot simpler. It seems our line SVG file adds 1px of 
padding on each side:
  
  F7922297: image.png 
  
  @ndavis do you think it's alright to remove this padding?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

2020-01-23 Thread Filip Fila 
filipf added a comment.


  In D26866#599653 , @ngraham wrote:
  
  > When using the Breeze style, the blue selection line no longer touches the 
separator line:
  >
  > F796: Screenshot_20200123_073450.png 

  >
  > F7922231: Screenshot_20200123_073540.PNG 

  
  
  Unfortunately not, yeah. It happens with all themes and is due to the changes 
in the height/width. The thing is if I leave the old height/width values the 
lines get rendered more dimly than they should so they need to be using the 
SVG's element size.
  
  Now as for why this element size generates padding, I'm not sure. I could 
look into PlasmaCore.Svg and PlasmaCore.SvgItem source files.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

2020-01-23 Thread Nathaniel Graham 
ngraham added a comment.


  When using the Breeze style, the blue selection line no longer touches the 
separator line:
  
  F796: Screenshot_20200123_073450.png 

  
  F7922231: Screenshot_20200123_073540.PNG 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

2020-01-23 Thread Filip Fila 
filipf updated this revision to Diff 74221.
filipf added a comment.


  use the element's own dimensions for geometry instead of hardcoding

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26866?vs=74218=74221

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

2020-01-23 Thread Filip Fila 
filipf added inline comments.

INLINE COMMENTS

> FullRepresentation.qml:127
>  }
> +height: Math.floor(units.devicePixelRatio)
> +width: root.width - 2 * units.gridUnit

maybe this doesn't need to be specified anymore? (and everywhere else in the 
diff)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

2020-01-23 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Kickoff's separators were drawn as rectangles which doesn't allow them to be 
themed.
  
  We have the infrastructure to theme lines though so this patch makes use of 
it.
  
  The benefit is that themes can now gracefully incorporate separators into 
their design.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart