D26926: Fix Windows build (Qt5.14 deprecation)

2020-01-27 Thread Johnny Jazeix 
jjazeix closed this revision.
jjazeix added a comment.


  Fix is commited, there are now link issues with KStatusNotifierItem: 
https://build.kde.org/view/Failing/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/2/console

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D26926

To: jjazeix, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26926: Fix Windows build (Qt5.14 deprecation)

2020-01-27 Thread Harald Sitter 
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  LGTM. Not that I understand where the sprintf function disappeared to.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D26926

To: jjazeix, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26926: Fix Windows build (Qt5.14 deprecation)

2020-01-26 Thread Johnny Jazeix 
jjazeix created this revision.
jjazeix added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jjazeix requested review of this revision.

REVISION SUMMARY
  Fixes 
https://build.kde.org/view/Failing/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/
  
  The fix still uses a deprecated method but it's the easier to put in place 
for now.
  A clean fix would be:
  
QTextStream ts();
ts << Qt::hex << "0x" << qSetFieldWidth(8) << Qt::right << i;
qDebug() << a;
  
  But as we are inside argument function, it would need a bit of rework.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D26926

AFFECTED FILES
  src/drkonqidialog.cpp

To: jjazeix, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart