D27034: Fix message box when passing a remote url that includes a file
sandsmark added a comment. This is wrong, isn't it? The logic was: if setDirectory is passed something that _isn't_ a directory, try to strip the filename. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27034 To: apol, #frameworks, ngraham Cc: sandsmark, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27034: Fix message box when passing a remote url that includes a file
This revision was automatically updated to reflect the committed changes. Closed by commit R135:317a899dc774: Fix message box when passing a remote url that includes a file (authored by apol). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27034?vs=74692=74725 REVISION DETAIL https://phabricator.kde.org/D27034 AFFECTED FILES src/platformtheme/kdeplatformfiledialoghelper.cpp To: apol, #frameworks, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27034: Fix message box when passing a remote url that includes a file
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The if was negated, I assume it was a typo TEST PLAN I don't get the following screenshot anymore REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D27034 AFFECTED FILES src/platformtheme/kdeplatformfiledialoghelper.cpp To: apol, #frameworks Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
