D27074: [Applet]Add port check

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:8f0847af1d17: [Applet]Add port check (authored by gvgeo, 
committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27074?vs=74811=74812

REVISION DETAIL
  https://phabricator.kde.org/D27074

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Add port check

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh you're right, I was looking at the wrong thing.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Add port check

[George Vogiatzis]

gvgeo added a comment.


  In D27074#604235 , @ngraham wrote:
  
  > Maybe only show the description when there's more than one input or output 
device? I thought the lack of a description for the single-device use case was 
a feature! :) It looks so nice and clean: F8062861: popup, one device.png 

  
  
  II don't see the problem, in this picture. I don't even know if it is before 
of after this patch.
  It looks fine, both devices show the port.
  
  This should not change anything. It is a bug fix.
  There are 2 descriptions, `Device description` and `Port description`. We 
prefer to show the Port description.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Add port check

[Nathaniel Graham]

ngraham added a comment.


  Maybe only show the description when there's more than one input or output 
device? I thought the lack of a description for the single-device use case was 
a feature! :) It looks so nice and clean: F8062861: popup, one device.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Add port check

[George Vogiatzis]

gvgeo updated this revision to Diff 74811.
gvgeo added a comment.


  Added port.description too.
  There is port.description.length now, better safe than sorry.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27074?vs=74810=74811

BRANCH
  check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27074

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Add port check

[George Vogiatzis]

gvgeo added a comment.


  Give 5 min to update the code.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart