D27090: Replace config.h with target_compile_definitions

2020-02-12 Thread Mikhail Zolotukhin 
gikari abandoned this revision.
gikari added a comment.


  Fair point.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27090

To: gikari
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27090: Replace config.h with target_compile_definitions

2020-02-03 Thread Aleix Pol Gonzalez 
apol added a comment.


  I wouldn't say it's simpler. If anything it's easier to inspect the value 
that is being passed from your editor.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27090

To: gikari
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27090: Replace config.h with target_compile_definitions

2020-02-01 Thread Mikhail Zolotukhin 
gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  One line in CMakeLists.txt is simpler, than the whole generated file.

TEST PLAN
  Relaunch `kded5`, open GTK Settings in Application style KCM and check if the 
previews are working.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  configh-to-compile-def

REVISION DETAIL
  https://phabricator.kde.org/D27090

AFFECTED FILES
  CMakeLists.txt
  config.h.cmake
  kded/CMakeLists.txt
  kded/themepreviewer.cpp

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart