D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> apol wrote in konsoleprofiles.cpp:155
> Why has the relevance code been removed?

It has been refactored and is now in line 132/188:
`match.setRelevance((float) term.length() / (float) data.displayName.length());`

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Aleix Pol Gonzalez]

apol added a comment.


  If you ask me, this patch does many things:
  
  - fixes an issue
  - changes coding style
  - does some code bits a bit more differently.
  
  It's hard to review for me, I hope someone else more familiar with the 
codebase can.

INLINE COMMENTS

> konsoleprofiles.cpp:155
> -
> -if (profileData.displayName.compare(term, 
> Qt::CaseInsensitive) == 0) {
> -match.setRelevance(1.0);

Why has the relevance code been removed?

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Alexander Lohnau]

alex added a comment.


  Ping :-)

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks like a sane clean-up to me. #konsole 
 and.or #plasma 
 folks?

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Alexander Lohnau]

alex updated this revision to Diff 75930.
alex added a comment.


  Rebase patch as requested

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27098?vs=75724=75930

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/CMakeLists.txt
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Nathaniel Graham]

ngraham added a comment.


  Can you rebase this patch now?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Alexander Lohnau]

alex updated this revision to Diff 75724.
alex added a comment.


  Remove unnecessary include, simplify

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27098?vs=74853=75724

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/CMakeLists.txt
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Alexander Lohnau]

alex updated this revision to Diff 74853.
alex added a comment.


  Allow search for profiles without "konsole" prefix

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27098?vs=74852=74853

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Alexander Lohnau]

alex created this revision.
alex added reviewers: davidedmundson, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Now Konsole is actually startet when an option is selected.
  Additionally the match method has been rewritten and the profiles are only 
loaded when the plugin
  is initialized or the config folder changes.

TEST PLAN
  Create different profiles and start the runner using the keyword "konsole", 
all profiles should show
  up, if one is selected, konsole launches with this profile.
  To filter the profiles you can type "konsole KEYWORD" and only the profiles 
that contain the keyword show up.
  Furthermore you can create/edit/delete new profiles after the runner is 
initailized and they still show up.

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart