D27138: [Applet]Restore naming convention for devices.

[Nathaniel Graham]

ngraham added a comment.


  I'm willing to be overruled if everybody else prefers the proposed change. :)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27138

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: cgiboudeaux, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27138: [Applet]Restore naming convention for devices.

[George Vogiatzis]

gvgeo added a comment.


  In D27138#605645 , @ngraham wrote:
  
  > > Makes 1 check and apply both for playback and recording devices.
  >
  > Are you sure that makes sense? If I have two outputs but only one input (a 
common setup) then I don't want my microphone having an unnecessarily long 
description. Might be nicer to keep the current approach of checking for 
multiple inputs and outputs separately IMO.
  
  
  And maybe wander which device has the mic.
  I would love to hear from others, If they have a preference on this. 2 
separate checks or 1 ?
  
  I will make the change later.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27138

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: cgiboudeaux, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27138: [Applet]Restore naming convention for devices.

[Nathaniel Graham]

ngraham added a comment.


  > Makes 1 check and apply both for playback and recording devices.
  
  Are you sure that makes sense? If I have two outputs but only one input (a 
common setup) then I don't want my microphone having an unnecessarily long 
description. Might be nicer to keep the current approach of checking for 
multiple inputs and outputs separately IMO.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27138

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: cgiboudeaux, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27138: [Applet]Restore naming convention for devices.

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Restores naming convention for devices, before the Layout update.
  Display both device name and port if there is more than one device.
  Makes 1 check and apply both for playback and recording devices.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  devicesCount (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27138

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: cgiboudeaux, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart