D27142: Have authhelper define config file paths on its own

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:c4b41ffe6660: Have authhelper define config file paths on 
its own (authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27142?vs=75005=75309

REVISION DETAIL
  https://phabricator.kde.org/D27142

AFFECTED FILES
  sddmauthhelper.cpp
  src/sddmkcm.cpp
  src/sddmkcm.h

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[David Edmundson]

davidedmundson added a comment.


  Yes

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  decoupled-config-path (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27142

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[Filip Fila]

filipf added a comment.


  5.18 then, right?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  decoupled-config-path (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27142

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[Filip Fila]

filipf updated this revision to Diff 75005.
filipf added a comment.


  undo changes for mSddmConfig and kill mSddmOldConfig

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27142?vs=74955=75005

BRANCH
  decoupled-config-path (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27142

AFFECTED FILES
  sddmauthhelper.cpp
  src/sddmkcm.cpp
  src/sddmkcm.h

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[David Edmundson]

davidedmundson added a comment.


  oh, then kill it

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27142

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[Filip Fila]

filipf added a comment.


  In D27142#605960 , @davidedmundson 
wrote:
  
  > I dunno, what is it?
  
  
  something I added before because I thought the 
`/etc/sddm.conf.d/kde_settings.conf` path should also be specified here. That 
was to be `mSddmConfig` and then `/etc/sddm.conf` was meant to be 
`mSddmOldConfig`

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27142

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[David Edmundson]

davidedmundson added a comment.


  I dunno, what is it?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27142

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> davidedmundson wrote in sddmkcm.cpp:55
> I don't think this is right.
> 
> This file is added below:
> 
>   systemConfigFiles = 
> QDir(QLatin1String(SDDM_SYSTEM_CONFIG_DIR)).entryList(QDir::Files | 
> QDir::NoDotAndDotDot, QDir::LocaleAware);
> 
> loops through every file in /etc/sddm.conf.d

is `mSddmOldConfig` even necessary here?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27142

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27142: Have authhelper define config file paths on its own

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> sddmkcm.cpp:55
>  
> -mSddmConfig = 
> KSharedConfig::openConfig(QStringLiteral(SDDM_CONFIG_FILE), 
> KConfig::CascadeConfig);
> +mSddmConfig = KSharedConfig::openConfig(QString 
> {QLatin1String(SDDM_CONFIG_DIR "/") + QStringLiteral("kde_settings.conf")}, 
> KConfig::CascadeConfig);
>  

I don't think this is right.

This file is added below:

  systemConfigFiles = 
QDir(QLatin1String(SDDM_SYSTEM_CONFIG_DIR)).entryList(QDir::Files | 
QDir::NoDotAndDotDot, QDir::LocaleAware);

loops through every file in /etc/sddm.conf.d

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27142

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart