D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  I think I have the old network manager. I will submit patches.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  Weird. I can't reproduce, neither in my compiled nor stable install:
  F8176254: Screenshot_20200314_233208.png 

  But then again, apparently it's not master-y master, so maybe something 
changed?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Nathaniel Graham]

ngraham added a comment.


  Just noticed that there are various system tray applets whose main 
content/toolbar areas need a bit more of a top margin now: F8176236: 
Screenshot_20200314_160647.png  F8176238: 
Screenshot_20200314_160805.png 
  
  It looks like this is not a universal thing and so will need to be fixed 
applet-by-applet. Could you submit patches for those?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f4195688e68e: Created a top area based on 
widgets/toparea.svg (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77514=77628

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  The title being moved to the right is a pre-existing feature/bug caused by 
some code in the system tray. Nice work!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove requested review of this revision.
niccolove added a comment.


  Works for me!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77514.
niccolove added a comment.


  - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into 
systray_toparea
  

  
  remove unrelated change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77512=77514

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77512.
niccolove added a comment.


  Removed head

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77510=77512

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:43
>  
> -RowLayout {
> -
> -PlasmaExtras.Heading {
> -id: heading
> -Layout.fillWidth: true
> -level: 1
> -Layout.leftMargin: {
> -//Menu mode
> -if (!activeApplet && hiddenItemsView.visible && 
> !LayoutMirroring.enabled) {
> -return units.smallSpacing;
> -
> -//applet open, sidebar
> -} else if (activeApplet && hiddenItemsView.visible && 
> !LayoutMirroring.enabled) {
> -return hiddenItemsView.width + units.largeSpacing;
> -
> -//applet open, no sidebar
> -} else {
> -return units.smallSpacing;
> +<<< HEAD
> +PlasmaExtras.PlasmoidHeading {

merge conflict remnant

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77510.
niccolove added a comment.


  - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into 
systray_toparea

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77416=77510

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77416.
niccolove added a comment.


  Trailing spaces

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77412=77416

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77412.
niccolove added a comment.


  Third one's a charm

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77411=77412

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77411.
niccolove added a comment.


  Second try of getting rid of unrelated changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77410=77411

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77410.
niccolove added a comment.


  Trying to get rid of unrelated changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77409=77410

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77409.
niccolove added a comment.


  - Merge branch 'master' into topbar

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76823=77409

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76823.
niccolove added a comment.


  Make anchors fill parent

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76530=76823

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> mart wrote in ExpandedRepresentation.qml:48
> not in all places you will have access to a dialog. the magic correct values 
> should come from the toparea margins itself done to go well with the 
> correspoding background svg.
> 
> in the end, i would like to have this in a control... i kinda hope a standard 
> toolBar control (will need some special casing when that style is running in 
> plasma or an app in plasma mobile

Okay, I tried to create a new component for this on 
https://phabricator.kde.org/D27695. I did not use toolBar because it was 
already using a different svg, but if you think that's the best idea, I can 
investigate that

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76530.
niccolove added a comment.


  Using new TopArea element from PlasmaComponents

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76529=76530

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76529.
niccolove added a comment.


  - Merge branch 'master' into topbar

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76374=76529

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  Ok - I think I got it. I will try to create a generic PlasmaCore.TopArea 
element and use it here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> mart wrote in ExpandedRepresentation.qml:48
> not in all places you will have access to a dialog. the magic correct values 
> should come from the toparea margins itself done to go well with the 
> correspoding background svg.
> 
> in the end, i would like to have this in a control... i kinda hope a standard 
> toolBar control (will need some special casing when that style is running in 
> plasma or an app in plasma mobile

I've done the first part (the magic correct values should come from the toparea 
margins).

Regarding the control, I'm not sure how it could be done, since the usage of 
the toparea element changes a lot:

- On the systemtray, it includes a big header and buttons on the right
- On the notifications, it includes a small header / text and buttons on the 
right
- On kickoff, it should include the entire area with the profile picture, name 
and password.

How could that be done?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76374.
niccolove added a comment.


  Used toparea margins rather than systray dialog.margins

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=75095=76374

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:48
> +fill: parent
> +leftMargin: -dialog.margins.left
> +topMargin: -dialog.margins.top

not in all places you will have access to a dialog. the magic correct values 
should come from the toparea margins itself done to go well with the 
correspoding background svg.

in the end, i would like to have this in a control... i kinda hope a standard 
toolBar control (will need some special casing when that style is running in 
plasma or an app in plasma mobile

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  See D27444 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Nathaniel Graham]

ngraham added a comment.


  Can you submit the patch that adds `widgets/toparea` so I can play around 
with this here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  I'm afraid I need help here, I can't figure out the layout.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Nathaniel Graham]

ngraham added a comment.


  In D27189#606970 , @niccolove 
wrote:
  
  > > The reason why the text is now pushed over is because you added the new 
`PlasmaCore.FrameSvgItem` *inside* the `RowLayout` that contains the `Heading`. 
If anything the reverse should be true; the `RowLayout` should be inside the 
new header SVG.
  >
  > That can't be done as far as I know - elements are not displayed correctly 
when inside. Or maybe it's because I should use Layouts better?
  
  
  I think it should work if you make the `FrameSvgItem` an item inside the 
top-level `ColumnLayout`, make it fill the width, and make the `RowLayout` a 
chilt item of the svg with `anchors.fill: parent`.
  
  > 
  > 
  >> Also you can't set anchors on an item inside a Layout; it causes binding 
loops. Anchors are only for positioning items that are outside of Layouts. 
Items inside Layouts get positioned using properties like `Layout.fillWidth, 
`Layout.Alignment`, `Layout.maximumWidth`, and so on.
  > 
  > I'd do that, but as far as I know Layout does not support the negative 
margin I need to expand the area to the borders :-/
  
  Then you can set the negative margins on the top-level layout, and re-add 
them as needed for the child items that are below the header. Not ideal though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  In D27189#606914 , @ngraham wrote:
  
  > Yeah, so you'll want to submit a plasma-frameworks patch which includes the 
new SVG and mark this as depending on it.
  
  
  Okay
  
  > The reason why the text is now pushed over is because you added the new 
`PlasmaCore.FrameSvgItem` *inside* the `RowLayout` that contains the `Heading`. 
If anything the reverse should be true; the `RowLayout` should be inside the 
new header SVG.
  
  That can't be done as far as I know - elements are not displayed correctly 
when inside. Or maybe it's because I should use Layouts better?
  
  > Also you can't set anchors on an item inside a Layout; it causes binding 
loops. Anchors are only for positioning items that are outside of Layouts. 
Items inside Layouts get positioned using properties like `Layout.fillWidth, 
`Layout.Alignment`, `Layout.maximumWidth`, and so on.
  
  I'd do that, but as far as I know Layout does not support the negative margin 
I need to expand the area to the borders :-/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Yeah, so you'll want to submit a plasma-frameworks patch which includes the 
new SVG and mark this as depending on it.
  
  The reason why the text is now pushed over is because you added the new 
`PlasmaCore.FrameSvgItem` *inside* the `RowLayout` that contains the `Heading`. 
If anything the reverse should be true; the `RowLayout` should be inside the 
new header SVG.
  
  Also you can't set anchors on an item inside a Layout; it causes binding 
loops. Anchors are only for positioning items that are outside of Layouts. 
Items inside Layouts get positioned using properties like `Layout.fillWidth, 
`Layout.Alignment`, `Layout.maximumWidth`, and so on.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Noah Davis]

ndavis added a comment.


  In D27189#606790 , @niccolove 
wrote:
  
  > ... The svg should be created (in a different patch, I thought?)
  
  
  I just realized this is plasma-workspace, not plasma-framework. My bad.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  In D27189#606788 , @ndavis wrote:
  
  > .+1 to this idea. I noticed that the separator on the left is less dark. 
I'm not necessarily opposed to that, but is it intentional? Also, where is 
toparea.svg? I don't see it in `breeze/widgets/`
  
  
  The line color is accidental, I should fix that. The svg should be created 
(in a different patch, I thought?)
  The one I'm currently using is:
  F8088084: test.svg 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Noah Davis]

ndavis added a comment.


  .+1 to this idea. I noticed that the separator on the left is less dark. I'm 
not necessarily opposed to that, but is it intentional? Also, where is 
toparea.svg? I don't see it in `breeze/widgets/`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart