D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  In D27199#629881 , @manueljlin 
wrote:
  
  > In D27199#627422 , @gvgeo wrote:
  >
  > > Differently sized icons are about to be restored in D28034 
.
  >
  >
  > Nice! Thanks
  
  
  You should thank @ngraham. He is the one making these small changes, 
including the password field size, in that patch.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  In D27199#627422 , @gvgeo wrote:
  
  > Differently sized icons are about to be restored in D28034 
.
  
  
  Nice! Thanks
  
  >> ...text indicator replaced with a 1px divider...   Is it a good idea to 
tweak it or is it better to leave it like it is?
  > 
  > The alternative is the first version from T10470 
 mocups, right? If #VDG 
 team doesn't like as it is, don't see a 
reason to keep it as it is.
  
  Yes, it would be like the first mockup
  
  > Would be nice to hear about details labels too, which have 0.6 opacity now:
  >  F8098508: Screenshot_20200211_234124.png 

  
  LGTM
  
  > And of course any other change, to avoid changing the UI with every release.
  
  If you could align the password field to the padding like this it would be 
great F8182886: image.png 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  Differently sized icons are about to be restored in D28034 
.
  
  > ...text indicator replaced with a 1px divider...   Is it a good idea to 
tweak it or is it better to leave it like it is?
  
  The alternative is the first version from T10470 
 mocups, right? If #VDG 
 team doesn't like as it is, don't see a 
reason to keep it as it is.
  
  Would be nice to hear about details labels too, which have 0.6 opacity now:
  F8098508: Screenshot_20200211_234124.png 

  
  And of course any other change, to avoid changing the UI with every release.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  I know this is closed now, but some people from the VDG didn't like the text 
indicator replaced with a 1px divider and the differently sized networks. Is it 
a good idea to tweak it or is it better to leave it like it is?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Jan Grulich]

jgrulich added a comment.


  Looks this changed introduced an issue. The traffic monitor doesn't fit into 
the applet.
  
  See picture below:
  F8145280: plasma-nm.png 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:24b737bc6d5c: [Applet]Update layout based on T10470 
(authored by gvgeo).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=76526=76576

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  LGTM! Nice work.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  arcpatch-D27199_2

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 76526.
gvgeo edited the summary of this revision.
gvgeo added a comment.


  rebase

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=75906=76526

BRANCH
  arcpatch-D27199_2

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin accepted this revision as: manueljlin.
manueljlin added a comment.


  Looks good, let's wait for ngraham so he accepts as vdg

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  arcpatch-D27199_2

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  It will need rebase, there are some changes in master now which will be 
conflicting. Other than that I think it looks good, but I would like Nate to 
approve this from the UI point of view.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  arcpatch-D27199_2

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  ping

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  The worst problem I could found, by ignoring the margins.
  Theme "Underworld".
  F8110467: Screenshot_20200218_134914.png 


REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  1 picture, 1 problem, 2 issues.
  F8110442: Screenshot_20200218_124006.png 

  I understand why margins exist. But this, is wrong.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 75906.
gvgeo edited the test plan for this revision.
gvgeo added a dependency: D27392: [Applet]Add info messages..
gvgeo added a comment.


  TODO from the last update.
  Improved comments.
  Removed fill anchor from listview.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=75831=75906

BRANCH
  arcpatch-D27199_2

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  Thanks. Done: https://bugs.kde.org/show_bug.cgi?id=417816

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Jan Grulich]

jgrulich added a comment.


  In D27199#613246 , @ngraham wrote:
  
  > In D27199#612689 , @jgrulich 
wrote:
  >
  > > This is probably not related to the UI, it might be issue in the 
internals. Can you open a bug for it? Ideally if you can restart plasmashell 
and enable plasma-nm debug
  >
  >
  > Will do. How do I do enable plasma-nm debug?
  
  
  Use export QT_LOGGING_RULES=plasma-nm*.debug=true
  
  More details: https://techbase.kde.org/Projects/Solid/Plasma-nm

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  In D27199#612689 , @jgrulich wrote:
  
  > This is probably not related to the UI, it might be issue in the internals. 
Can you open a bug for it? Ideally if you can restart plasmashell and enable 
plasma-nm debug
  
  
  Will do. How do I do enable plasma-nm debug?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 75831.
gvgeo edited the summary of this revision.
gvgeo added a dependency: D27392: [Applet]Add info messages..
gvgeo added a comment.


  Changes:
  Removed some parts that were split into separate patches.
  Reintroduce background.
  Moved highlight in ListItem.
  Removed heading and moved separator in ListItem.
  
  TODO:
  Add `opacity: 0.6` for details after D27393 
 commit.
  Remove 1 extra smallSpacing in switchbutton after D27453 
 commit.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=75498=75831

BRANCH
  layoutsplit2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Jan Grulich]

jgrulich added a comment.


  In D27199#611665 , @ngraham wrote:
  
  > In D27199#611308 , @gvgeo wrote:
  >
  > > I made 3 smaller patches, to decrease this patch's size. D27391 
 D27392 
 D27393 
  > >
  > > @ngraham Before I make any change here, can you tell me if you can still 
reproduce the problem, with this diff on **master**?
  > >  F8102982: withoutCpp.diff 
  > >  It exludes changes in modelitem and C++ in general.
  >
  >
  > Yes, I can still reproduce the issue with this diff applied on top of 
master. HOWECVER! I just noticed that I can reproduce the issue on master right 
now, with no patches. I can't believe I missed this before, sorry!
  
  
  This is probably not related to the UI, it might be issue in the internals. 
Can you open a bug for it? Ideally if you can restart plasmashell and enable 
plasma-nm debug and attach the log to your bug. Thanks.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  In D27199#611308 , @gvgeo wrote:
  
  > I made 3 smaller patches, to decrease this patch's size. D27391 
 D27392 
 D27393 
  >
  > @ngraham Before I make any change here, can you tell me if you can still 
reproduce the problem, with this diff on **master**?
  >  F8102982: withoutCpp.diff 
  >  It exludes changes in modelitem and C++ in general.
  
  
  Yes, I can still reproduce the issue with this diff applied on top of master. 
HOWECVER! I just noticed that I can reproduce the issue on master right now, 
with no patches. I can't believe I missed this before, sorry!

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  I made 3 smaller patches, to decrease this patch's size. D27391 
 D27392 
 D27393 
  
  @ngraham Before I make any change here, can you tell me if you can still 
reproduce the problem, with this diff on **master**?
  F8102982: withoutCpp.diff 
  It exludes changes in modelitem and C++ in general.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  Can reproduce; it's consistent.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  Added highlight as mention, and brought back background. To do that, had to 
ignore, theme's margins.
  I need to clean code, before uploading.
  
  **I'm not so sure about this:**
  When a row is expanded, moving from bottom to top. **Highlight disappears 
with button, But only the buttton appears on the row above**, untill you reach 
the main row.
  F8101293: breezedark.mkv 
  F8101292: air.mkv 
  
  Alternative can restore highlight as it was. Higlight the whole item.
  I'd like to avoid the hand pointer. Because it will be a hand most of the 
time.
  
  ---
  
  > I see my currently connected network twice
  
  Is this onetime thing or can reproduce?
  I wonder if it is a core problem. I don't believe I influenced the model. 
I'll take a look again of course.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  Hmm, now I see my currently connected network twice:
  
  F8100139: Screenshot_20200212_131124.png 


REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Jan Grulich]

jgrulich added a comment.


  I like it. I didn't go through the code changes yet, I'll wait until you 
finish it completely.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo planned changes to this revision.
gvgeo added a comment.


  Clicking and  highlight only on the main row, and only when hover.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  Pretty nice. If the list items are no longer going to have a selection 
highlight but still open up/unfold when single-clicked, then the cursor should 
change to a pointing hand when hovering over them.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart