D27219: Center placeholder texts in system tray popups

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c5a6ba369c4e: Center placeholder texts in system tray 
popups (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27219?vs=75258=75284

REVISION DETAIL
  https://phabricator.kde.org/D27219

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, ndavis, trmdi, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

[David Edmundson]

davidedmundson added a comment.


  From a code pov. +1
  
  I don't have an opinion on the UI change, but if vdg approve, ship it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  centered-placeholder-texts (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, ndavis, trmdi, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

[Nathaniel Graham]

ngraham updated this revision to Diff 75258.
ngraham marked an inline comment as done.
ngraham added a comment.


  Fill, don't center

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27219?vs=75184=75258

BRANCH
  centered-placeholder-texts (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27219

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, ndavis, trmdi, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> FullRepresentation.qml:41
>  PlasmaExtras.Heading {
> +anchors.centerIn: parent
> +horizontalAlignment: Text.AlignHCenter

Why not fill given you set the text alignment

REPOSITORY
  R120 Plasma Workspace

BRANCH
  centered-placeholder-texts (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, ndavis, trmdi, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Visually, LGTM

REPOSITORY
  R120 Plasma Workspace

BRANCH
  centered-placeholder-texts (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma, ndavis
Cc: ndavis, trmdi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27219: Center placeholder texts in system tray popups

[Tranter Madi]

trmdi added a comment.


  Could you post screenshots of a same tab?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma
Cc: trmdi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

[Nathaniel Graham]

ngraham added a comment.


  The strings could use a bit of adjustment, but I'll have to do that on master.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27219: Center placeholder texts in system tray popups

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We use this centered style in many other places and are moving towards using 
it
  everywhere. This patch applies the same style to the System Tray popups for
  notifications and devices, which were still using the old style.

TEST PLAN
  F8090777: notifications.png 
  
  F8090776: device notifier.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  centered-placeholder-texts (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27219

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart