D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3c4ba1aee620: [applets/taskmanager] Don't show 
tooltip subtitle that's identical to the main… (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27273?vs=75375&id=75376

REVISION DETAIL
  https://phabricator.kde.org/D27273

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

[Nathaniel Graham]

ngraham updated this revision to Diff 75375.
ngraham marked an inline comment as done.
ngraham added a comment.


  Triple equals FTW

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27273?vs=75323&id=75375

BRANCH
  dont-be-redundant-in-tooltips (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27273

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

[Filip Fila]

filipf accepted this revision.
filipf added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ToolTipInstance.qml:123
>  opacity: 0.75
> -visible: !hasPlayer && text.length !== 0
> +visible: !hasPlayer && text.length !== 0 && text != 
> appNameHeading.text
>  }

I think they want us using !== now

REPOSITORY
  R119 Plasma Desktop

BRANCH
  dont-be-redundant-in-tooltips (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27273

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Before-and-after pictures below should be self-explanatory:

TEST PLAN
  Before: F8094802: Before.png 
  After: F8094803: After.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  dont-be-redundant-in-tooltips (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27273

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart