D27420: [Applet]Improvements for unavailable port.

2020-02-26 Thread George Vogiatzis 
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:ada3385d04c3: [Applet]Improvements for unavailable port. 
(authored by gvgeo).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27420?vs=75899=76479

REVISION DETAIL
  https://phabricator.kde.org/D27420

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

2020-02-25 Thread George Vogiatzis 
gvgeo added a comment.


  Don't see anyone objecting, will commit later.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  FreeThePort3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

2020-02-18 Thread George Vogiatzis 
gvgeo updated this revision to Diff 75899.
gvgeo added a comment.


  Rebase

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27420?vs=75817=75899

BRANCH
  FreeThePort3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

2020-02-17 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  LGTM. #plasma  folks?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

2020-02-17 Thread George Vogiatzis 
gvgeo updated this revision to Diff 75817.
gvgeo added a comment.


  avoid i18n puzzles

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27420?vs=75739=75817

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

2020-02-16 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> gvgeo wrote in ListItemBase.qml:357
> I wanted to do this change, but this is old code from 5.17.  I believe that 
> translated history must exist, and will automatically be used.

Better to change it now to avoid the string puzzle entirely IMO

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

2020-02-16 Thread George Vogiatzis 
gvgeo added a comment.


  > ...it solves the reporter's problem...
  
  Not exactly. When an available port gets selected(or is active) port option 
will disappear again. Only enables complete port selection while an unavailable 
is the default.
  
  > Or has the code diverged between 5.18 and master too much?
  
  Yeah, too many patches. In master, you know, we changed the UI, limited the 
port selection...  :D

INLINE COMMENTS

> ListItemBase.qml:357
> +if (port.name == "analog-output-speaker" || 
> port.name == "analog-input-microphone-internal") {
> +menuItem.text += i18nc("Port is 
> unavailable", " (unavailable)");
> +} else {

I wanted to do this change, but this is old code from 5.17.  I believe that 
translated history must exist, and will automatically be used.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

2020-02-15 Thread Pino Toscano 
pino added inline comments.

INLINE COMMENTS

> ListItemBase.qml:357
> +if (port.name == "analog-output-speaker" || 
> port.name == "analog-input-microphone-internal") {
> +menuItem.text += i18nc("Port is 
> unavailable", " (unavailable)");
> +} else {

please avoid i18n puzzles, and use placeholders instead; for example

  i18nc("Port is unavailable", "%1 (unavailable)", port_description);

> ListItemBase.qml:359
> +} else {
> +menuItem.text += i18nc("Port is unplugged", 
> " (unplugged)");
> +}

ditto

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

2020-02-15 Thread Nathaniel Graham 
ngraham added a comment.


  Or has the code diverged between 5.18 and master too much?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

2020-02-15 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  That's a clever fix. Very nice how it solves the reporter's problem without 
changing the UI at all for everyone else who doesn't need it. No regressions 
found in testing.
  
  What do you think; should we target 5.18.1 for this bugfix?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

2020-02-15 Thread George Vogiatzis 
gvgeo created this revision.
gvgeo added reviewers: Plasma, drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Enable unavailable ports to be active, which was added in 10ab204a62cf 
.
  Enable port selection in case an unavailable port is active.

TEST PLAN
  Before: Choosing an unavailable port from pavucontrol was impossible.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart