D27461: Sync Plasma theme settings instead of copying the plasmarc file

2020-02-17 Thread Filip Fila
filipf added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:138
> +QSharedPointer themeConfig = 
> openConfig(themeConfigLocation);
> +
> themeConfig->group(QStringLiteral("Theme")).writeEntry(QStringLiteral("name"),
>  args[QStringLiteral("plasmaTheme")].toString());
> +const char* themeConfigLocationConverted = 
> themeConfigLocation.toLocal8Bit().data();

do I need to do `themeConfig->sync`? It seems to work as intended without it, 
even when just updating the entry.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27461

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27461: Sync Plasma theme settings instead of copying the plasmarc file

2020-02-17 Thread Filip Fila
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The first and the easiest part of finishing T12710 
.
  
  Instead of copying the user's plasmarc file in order to have SDDM use their 
Plasma theme, we read the user value and create the SDDM user's config 
ourselves.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  safer-plasmarc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27461

AFFECTED FILES
  sddmauthhelper.cpp
  src/advancedconfig.cpp

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart