D27513: Kill Runner: Remove duplicate function calls and refactor
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6f103ebd7b3a: Kill Runner: Remove duplicate function calls and refactor (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=82669&id=82713 REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES runners/kill/CMakeLists.txt runners/kill/killrunner.cpp runners/kill/killrunner.h runners/kill/killrunner_config.cpp runners/kill/killrunner_config.h To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27513: Kill Runner: Remove duplicate function calls and refactor
alex updated this revision to Diff 82669. alex added a comment. Formatting REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=82666&id=82669 BRANCH arcpatch-D27513_1 REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES runners/kill/CMakeLists.txt runners/kill/killrunner.cpp runners/kill/killrunner.h runners/kill/killrunner_config.cpp runners/kill/killrunner_config.h To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27513: Kill Runner: Remove duplicate function calls and refactor
alex updated this revision to Diff 82666. alex added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=81006&id=82666 BRANCH arcpatch-D27513_1 REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES runners/kill/CMakeLists.txt runners/kill/killrunner.cpp runners/kill/killrunner.h runners/kill/killrunner_config.cpp runners/kill/killrunner_config.h To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27513: Kill Runner: Remove duplicate function calls and refactor
alex updated this revision to Diff 81006. alex added a comment. Fix small issue from splitting up patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76149&id=81006 BRANCH arcpatch-D27513 REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES runners/kill/CMakeLists.txt runners/kill/killrunner.cpp runners/kill/killrunner.h runners/kill/killrunner_config.cpp runners/kill/killrunner_config.h To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27513: Kill Runner: Remove duplicate function calls and refactor
alex added a comment. Friendly Ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27513 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27513: Kill Runner: Remove duplicate function calls and refactor
alex updated this revision to Diff 76149. alex marked an inline comment as done. alex added a comment. Revert moving of config keys from commit "Remove duplicate function calls, move config keys to new file" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76085&id=76149 BRANCH killrunner_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES runners/kill/CMakeLists.txt runners/kill/killrunner.cpp runners/kill/killrunner.h runners/kill/killrunner_config.cpp runners/kill/killrunner_config.h To: alex, davidedmundson, ngraham, broulik, meven Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27513: Kill Runner: Remove duplicate function calls and refactor
alex updated this revision to Diff 76085. alex added a comment. Pass file directly to add_library REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76023&id=76085 BRANCH killrunner_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES runners/kill/CMakeLists.txt runners/kill/config_keys.h runners/kill/killrunner.cpp runners/kill/killrunner.h runners/kill/killrunner_config.cpp runners/kill/killrunner_config.h To: alex, davidedmundson, ngraham, broulik, meven Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27513: Kill Runner: Remove duplicate function calls and refactor
apol added a comment.
Seems to me like there's 2 very different changes here, can you split in 2
reviews?
INLINE COMMENTS
> CMakeLists.txt:20
> +set(krunner_kill_SRCS killrunner.cpp)
> add_library(krunner_kill MODULE ${krunner_kill_SRCS})
> target_link_libraries(krunner_kill
just pass it to add_library
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D27513
To: alex, davidedmundson, ngraham, broulik, meven
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D27513: Kill Runner: Remove duplicate function calls and refactor
alex updated this revision to Diff 76023. alex added a comment. Remove QDebug include, add license REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76022&id=76023 BRANCH killrunner_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES runners/kill/CMakeLists.txt runners/kill/config_keys.h runners/kill/killrunner.cpp runners/kill/killrunner.h runners/kill/killrunner_config.cpp runners/kill/killrunner_config.h To: alex, davidedmundson, ngraham, broulik, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27513: Kill Runner: Remove duplicate function calls and refactor
alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Duplicate function calls to load the config in the runner/config have been removed. Additionally the config keys/sorting enum have been moved to a new file, before this the runner included the header of the config class. The actions of the runner are also refactored, similar to https://phabricator.kde.org/D3688. Also the user (owner of process) has been removed from the subtext, because the second line is not shown and adding the user info to the same line would be too long. TEST PLAN Should compile and kill processes as before. REPOSITORY R120 Plasma Workspace BRANCH killrunner_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES runners/kill/CMakeLists.txt runners/kill/config_keys.h runners/kill/killrunner.cpp runners/kill/killrunner.h runners/kill/killrunner_config.cpp runners/kill/killrunner_config.h To: alex, davidedmundson, ngraham, broulik, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
