D2754: Touchpad KDED: fix metadata warning

2018-11-16 Thread David Edmundson 
davidedmundson commandeered this revision.
davidedmundson edited reviewers, added: knambiar; removed: davidedmundson.
davidedmundson added a comment.


  This was merged at some point
  Closing the RR.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2754

To: davidedmundson, #plasma, mart, aacid, knambiar
Cc: aacid, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D2754: Touchpad KDED: fix metadata warning

2017-09-09 Thread Albert Astals Cid 
aacid added a comment.


  I can try having a look, not a mega expert myself though

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2754

To: knambiar, #plasma, davidedmundson, mart, aacid
Cc: aacid, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D2754: Touchpad KDED: fix metadata warning

2017-09-08 Thread Rajeesh K Nambiar 
knambiar added a comment.


  In https://phabricator.kde.org/D2754#143319, @aacid wrote:
  
  > So what's the status of this? needs landing? needs help?
  
  
  Thanks for offering the help, Albert!
  Trouble here is that the error is not reproducible. The last message in my 
logs is from Sep 04 (prior to that was Aug 22), so there isn't an easy way to 
ensure that this change fixes the issue.
  That said, going through other modules and similar error messages; I've 
another patch hopefully more correct. Could you review the updated version?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2754

To: knambiar, #plasma, davidedmundson, mart, aacid
Cc: aacid, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D2754: Touchpad KDED: fix metadata warning

2017-09-08 Thread Rajeesh K Nambiar 
knambiar updated this revision to Diff 19300.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2754?vs=6670=19300

REVISION DETAIL
  https://phabricator.kde.org/D2754

AFFECTED FILES
  kcms/touchpad/src/kded/kded_touchpad.desktop

To: knambiar, #plasma, davidedmundson, mart, aacid
Cc: aacid, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D2754: Touchpad KDED: fix metadata warning

2017-09-05 Thread Albert Astals Cid 
aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.


  So what's the status of this? needs landing? needs help?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2754

To: knambiar, #plasma, davidedmundson, mart, aacid
Cc: aacid, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Differential] [Commented On] D2754: Touchpad KDED: fix metadata warning

2016-09-13 Thread knambiar (Rajeesh K Nambiar) 
knambiar added a comment.


  Thanks for the review, but actually I am not convinced that this gets rid of 
the warning message. Sifting through the KF5 porting notes, I am not sure how 
this should be handled -- kded tries to load the plugin with just "name" and if 
not found it looks for "kded_name", which succeeds and emits this warning.
  Any suggestions what should be the right approach with KPluginLoader? Should 
it be always fed with JSON plugin metadata?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2754

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: knambiar, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2754: Touchpad KDED: fix metadata warning

2016-09-13 Thread mart (Marco Martin) 
mart accepted this revision.
mart added a reviewer: mart.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2754

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: knambiar, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2754: Touchpad KDED: fix metadata warning

2016-09-13 Thread davidedmundson (David Edmundson) 
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2754

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: knambiar, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 1 line] D2754: Touchpad KDED: fix metadata warning

2016-09-12 Thread knambiar (Rajeesh K Nambiar) 
knambiar created this revision.
knambiar added a reviewer: Plasma.
knambiar set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Get rid of kded warning:
  kf5.kded: found kded module "touchpad" by prepending 'kded_' to the library 
path, please fix your metadata

TEST PLAN
  Compiles.
  Log out and in again, warning disappeared, everything works ok - specifically 
kded disables touchpad while typing.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2754

AFFECTED FILES
  kcms/touchpad/src/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: knambiar, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas