D27554: reviews: expose the reviewed package version on the delegate

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:d58668698f5f: reviews: expose the reviewed package 
version on the delegate (authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27554?vs=76124&id=76549

REVISION DETAIL
  https://phabricator.kde.org/D27554

AFFECTED FILES
  discover/qml/ReviewDelegate.qml
  libdiscover/ReviewsBackend/ReviewsModel.cpp
  libdiscover/ReviewsBackend/ReviewsModel.h

To: apol, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27554: reviews: expose the reviewed package version on the delegate

[Aleix Pol Gonzalez]

apol added a comment.


  In D27554#615412 , @ngraham wrote:
  
  > Nice! How about putting the version next to the stars, up on the header row?
  
  
  Having 2 text fields growing one against each other is often a source of 
problems. Could work though.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27554

To: apol, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27554: reviews: expose the reviewed package version on the delegate

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  Nice! How about putting the version next to the stars, up on the header row?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27554

To: apol, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27554: reviews: expose the reviewed package version on the delegate

[Aleix Pol Gonzalez]

apol added a comment.


  F8119550: Screenshot_20200221_210428.png 
 #vdg 


REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27554

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27554: reviews: expose the reviewed package version on the delegate

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Helps show which version was reviewed to see if the critiques might have
  been figured out.
  
  BUG: 417675

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27554

AFFECTED FILES
  discover/qml/ReviewDelegate.qml
  libdiscover/ReviewsBackend/ReviewsModel.cpp
  libdiscover/ReviewsBackend/ReviewsModel.h

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart