D27645: [KCM]Align volume controls row
This revision was automatically updated to reflect the committed changes. Closed by commit R115:ca15ec82c121: [KCM]Align volume controls row (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76884&id=76909 REVISION DETAIL https://phabricator.kde.org/D27645 AFFECTED FILES src/kcm/package/contents/ui/DeviceListItem.qml src/kcm/package/contents/ui/StreamListItem.qml To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27645: [KCM]Align volume controls row
gvgeo updated this revision to Diff 76884. gvgeo added a comment. Fix rebase. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76874&id=76884 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645 AFFECTED FILES src/kcm/package/contents/ui/DeviceListItem.qml src/kcm/package/contents/ui/StreamListItem.qml To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27645: [KCM]Align volume controls row
gvgeo updated this revision to Diff 76874. gvgeo added a comment. Math round. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76873&id=76874 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645 AFFECTED FILES src/kcm/package/contents/ui/DeviceListItem.qml src/kcm/package/contents/ui/StreamListItem.qml To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27645: [KCM]Align volume controls row
gvgeo updated this revision to Diff 76873. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76519&id=76873 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645 AFFECTED FILES src/kcm/package/contents/ui/DeviceListItem.qml src/kcm/package/contents/ui/StreamListItem.qml To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27645: [KCM]Align volume controls row
ngraham added a comment. Needs a rebase REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27645: [KCM]Align volume controls row
gvgeo added a comment. In my opinion this is better even without the workaround. Only when scale is 100% for playback devices, look worse (first photo in before-after). REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27645: [KCM]Align volume controls row
gvgeo updated this revision to Diff 76519. gvgeo added a comment. Removed workaround. (It would be nice to mention breeze theme.) REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76353&id=76519 BRANCH scaleM (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645 AFFECTED FILES src/kcm/package/contents/ui/DeviceListItem.qml src/kcm/package/contents/ui/StreamListItem.qml To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27645: [KCM]Align volume controls row
gvgeo added a comment. Should I remove the slider workaround? And leave it with 2 pixel offset? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27645: [KCM]Align volume controls row
gvgeo added inline comments. INLINE COMMENTS > VolumeSlider.qml:43 > +// Workaround: Slider has 2 extra pixels at the bottom, used for the > tickmarks, which move it off-center. > +Layout.bottomMargin: -Math.round(slider.implicitHeight / 11) > + I tried to change qqc2-desktop-style but didn't had any effect. Wonder If I did something wrong, REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27645: [KCM]Align volume controls row
broulik added inline comments. INLINE COMMENTS > VolumeSlider.qml:43 > +// Workaround: Slider has 2 extra pixels at the bottom, used for the > tickmarks, which move it off-center. > +Layout.bottomMargin: -Math.round(slider.implicitHeight / 11) > + Eww. Can we fix the slider instead? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27645: [KCM]Align volume controls row
gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Align mute button, slider and percent text. Set proper margin for mute. Cut 2 extra pixels at the bottom of the slider, which are used for the tickmarks and move it off-center. TEST PLAN Before: After: REPOSITORY R115 Plasma Audio Volume Applet BRANCH scaleM (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645 AFFECTED FILES src/kcm/package/contents/ui/DeviceListItem.qml src/kcm/package/contents/ui/StreamListItem.qml src/kcm/package/contents/ui/VolumeSlider.qml To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
