D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled
This revision was automatically updated to reflect the committed changes. Closed by commit R119:3b2e4ddaa01a: [applets/taskmanager] Show PA-related features even when audio indicators are… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27684?vs=76495&id=76584 REVISION DETAIL https://phabricator.kde.org/D27684 AFFECTED FILES applets/taskmanager/package/contents/ui/Task.qml applets/taskmanager/package/contents/ui/main.qml To: ngraham, #plasma, hein Cc: hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Good stuff. REPOSITORY R119 Plasma Desktop BRANCH show-mute-feature-even-when-audio-indicators-are-disabled (branched from master) REVISION DETAIL https://phabricator.kde.org/D27684 To: ngraham, #plasma, hein Cc: hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled
gvgeo added inline comments.
INLINE COMMENTS
> main.qml:46
>
> +readonly property bool plasmaPaAvailable:
> Qt.createComponent("PulseAudio.qml").status === Component.Ready
> +
I get a feeling there are 2 instances now.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27684
To: ngraham, #plasma
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled
ngraham updated this revision to Diff 76495. ngraham added a comment. Brain fart; do it right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27684?vs=76494&id=76495 BRANCH show-mute-feature-even-when-audio-indicators-are-disabled (branched from master) REVISION DETAIL https://phabricator.kde.org/D27684 AFFECTED FILES applets/taskmanager/package/contents/ui/Task.qml applets/taskmanager/package/contents/ui/main.qml To: ngraham, #plasma Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled
ngraham updated this revision to Diff 76494. ngraham added a comment. Also check `audioIndicatorsEnabled` for safety REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27684?vs=76492&id=76494 BRANCH show-mute-feature-even-when-audio-indicators-are-disabled (branched from master) REVISION DETAIL https://phabricator.kde.org/D27684 AFFECTED FILES applets/taskmanager/package/contents/ui/Task.qml applets/taskmanager/package/contents/ui/main.qml To: ngraham, #plasma Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled
gvgeo added inline comments.
INLINE COMMENTS
> Task.qml:230
> +onAudioIndicatorsEnabledChanged: {
> +audioStreamIconLoader.active = audioIndicatorsEnabled;
> }
Better include hasAudioStream too, or will be active for all tasks, even if it
is not visible.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27684
To: ngraham, #plasma
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled
ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY There is a checkbox in the Task Manager settings with the text "Mark applications that play audio". Unchecking it does much more than no longer marking applications that play audio though; it disabled all PulseAudio-related features. This not only makes the label inaccurate, but it also seems undesirable; a user could quite reasonably wish to disable the audio indicators while still using PulseAudio-related functionality through the Task Manager (e.g. muting an app from the context menu). This patch makes the setting in question really and truly only show and hide the audio indicator icon on the Task; other PA-related functionality is always loaded when available. TEST PLAN Open an app or window that can play audio and start playing audio with it Make sure that audio indicators are visible Right-click on the task and see that there's Mute item (provided by PA Configure the Task Manager and disable audio indicators See that the audio indicator icon is gone from the task Right-click on the task and see that the Mute item is still there Configure the Task Manager again and re-enable audio indicators See that the audio indicator icon re-appears on the task BUG: 418164 FIXED-IN: 5.18.3 REPOSITORY R119 Plasma Desktop BRANCH show-mute-feature-even-when-audio-indicators-are-disabled (branched from master) REVISION DETAIL https://phabricator.kde.org/D27684 AFFECTED FILES applets/taskmanager/package/contents/ui/Task.qml applets/taskmanager/package/contents/ui/main.qml To: ngraham, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
