D27700: Change copy to binary to use a custom target that always runs

2020-02-27 Thread Aleix Pol Gonzalez
apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:86
>  make_directory 
> ${CMAKE_BINARY_DIR}/bin/org/kde/kirigami.2/)
> -add_custom_command(TARGET kirigamiplugin POST_BUILD
> +add_custom_command(TARGET copy_to_bin POST_BUILD
>  COMMAND ${CMAKE_COMMAND} -E

Maybe pass different COMMAND to the same add_custom_command? As is it reads 
like you're declaring the command several times.

See https://cmake.org/cmake/help/v3.13/command/add_custom_command.html

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27700

To: ahiemstra, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein


D27700: Change copy to binary to use a custom target that always runs

2020-02-27 Thread Arjen Hiemstra
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds an inital test to test whether ActionToolBar does the
  right thing. It does not yet cover display hints or custom
  components, but does cover using QQC2 action instead of Kirigami
  Action.

TEST PLAN
  The new test passes.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_test

REVISION DETAIL
  https://phabricator.kde.org/D27700

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/tst_actiontoolbar.qml
  src/CMakeLists.txt

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein