D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec
This revision was automatically updated to reflect the committed changes. Closed by commit R116:803b17ad39ef: Rename L2TP IPsec Settings dialog from Advanced to IPsec (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27763?vs=76729&id=76773 REVISION DETAIL https://phabricator.kde.org/D27763 AFFECTED FILES vpn/l2tp/CMakeLists.txt vpn/l2tp/l2tpadvanced.ui vpn/l2tp/l2tpadvancedwidget.cpp vpn/l2tp/l2tpadvancedwidget.h vpn/l2tp/l2tpipsec.ui vpn/l2tp/l2tpipsecwidget.cpp vpn/l2tp/l2tpipsecwidget.h vpn/l2tp/l2tpwidget.cpp vpn/l2tp/l2tpwidget.h To: dkosovic, jgrulich Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Makes sense. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27763 To: dkosovic, jgrulich Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec
dkosovic created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. dkosovic requested review of this revision. REVISION SUMMARY Calling the IPsec dialog Advanced is confusing, so rename it to IPsec. Also in a subsequent patch there is also an Advanced group box in the IPsec dialog which would have added more confusion.. The following git file name renames occur in the vpn/l2tp folder and are in the patch file. git mv l2tpadvancedwidget.cpp l2tpipsecwidget.cpp git mv l2tpadvancedwidget.h l2tpipsecwidget.h git mv l2tpadvanced.ui l2tpipsec.ui REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27763 AFFECTED FILES vpn/l2tp/CMakeLists.txt vpn/l2tp/l2tpadvanced.ui vpn/l2tp/l2tpadvancedwidget.cpp vpn/l2tp/l2tpadvancedwidget.h vpn/l2tp/l2tpipsec.ui vpn/l2tp/l2tpipsecwidget.cpp vpn/l2tp/l2tpipsecwidget.h vpn/l2tp/l2tpwidget.cpp vpn/l2tp/l2tpwidget.h To: dkosovic, jgrulich Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
