D27824: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  Wait, I think I understood the reason

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D27824

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:24f2bd58bb5a: Use consistent highlight (authored by 
niccolove).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27824?vs=77002=77205

REVISION DETAIL
  https://phabricator.kde.org/D27824

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  Seems correct to me - rather, the nm button is way too on the right. I could 
make that one consistent instead.

REPOSITORY
  R97 Bluedevil

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27824

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77002.
niccolove added a comment.


  Remove previous highlight

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27824?vs=76912=77002

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27824

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Need to adjust the button's right margin in `DeviceItem.qml` as well: 
F8149546: Screenshot_20200304_084053.png 
  
  Could be done in another patch.

REPOSITORY
  R97 Bluedevil

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27824

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This uses the PlasmaComponents.Highlight feature to be consistent with other 
lists

REPOSITORY
  R97 Bluedevil

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27824

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart