D27915: Use breeze icons for categories

2020-03-11 Thread Phabricator 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7a6e8f3bc52a: Use breeze icons for categories (authored 
by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27915?vs=77174=77392

REVISION DETAIL
  https://phabricator.kde.org/D27915

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml

To: guoyunhe, #plasma, apol
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-09 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Don't land before D27913 .

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma, apol
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-08 Thread Nathaniel Graham 
ngraham added a reviewer: apol.
ngraham added a comment.


  Hmm, your before and after screenshots look identical to me.
  
  What's the reason for this? To make them look better in High DPI mode? I 
thought that was already fixed with D27515: Icon: fix rendering of image: urls 
on High DPI 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma, apol
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread Yunhe Guo 
guoyunhe added a comment.


  In D27915#623862 , @davidre wrote:
  
  > In D27915#623859 , @guoyunhe 
wrote:
  >
  > > In D27915#623854 , @davidre 
wrote:
  > >
  > > > There is something wrong on your system, this is how before looks for 
me:
  > > >  F8163706: Screenshot_20200307_171017.PNG 

  > >
  > >
  > > Please ignore the content. I only want to compare the left panel.
  >
  >
  > Yes there is still a difference in the left panel in my screenshot compared 
to your before screenshot. Not pixelated and all categories colorful
  
  
  The "pixelated" icon only appears to HiDPI display. The "monochrome" icon 
only appears when the system has dejavu-fonts installed. It looks different in 
different distros.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread David Redondo 
davidre added a comment.


  In D27915#623859 , @guoyunhe wrote:
  
  > In D27915#623854 , @davidre 
wrote:
  >
  > > There is something wrong on your system, this is how before looks for me:
  > >  F8163706: Screenshot_20200307_171017.PNG 

  >
  >
  > Please ignore the content. I only want to compare the left panel.
  
  
  Yes there is still a difference in the left panel in my screenshot compared 
to your before screenshot. Not pixelated and all categories colorful

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread Yunhe Guo 
guoyunhe added a comment.


  In D27915#623854 , @davidre wrote:
  
  > There is something wrong on your system, this is how before looks for me:
  >  F8163706: Screenshot_20200307_171017.PNG 

  
  
  Please ignore the content. I only want to compare the left panel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread David Redondo 
davidre added a comment.


  There is something wrong on your system, this is how before looks for me:
  F8163706: Screenshot_20200307_171017.PNG 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 77174.
guoyunhe added a comment.


  Change object-group to object

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27915?vs=77172=77174

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27915

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml

To: guoyunhe, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread Yunhe Guo 
guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27915

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml

To: guoyunhe
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart