D27958: [SystemTray] Fix item size for very narrow panel

[Konrad Materka]

kmaterka added a comment.


  In D27958#627658 , @ngraham wrote:
  
  > After a few days of living with it, I've found that this patch causes the 
following issue with semi-random tray items getting smaller when a pop-up is 
opened:
  >
  > F8176616: vokoscreenNG-2020-03-14_23-35-16.webm 

  >
  > Could you investigate?
  
  
  Yes, I will take a look at this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27958

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Nathaniel Graham]

ngraham added a comment.


  After a few days of living with it, I've found that this patch causes the 
following issue with semi-random tray items getting smaller when a pop-up is 
opened:
  
  F8176616: vokoscreenNG-2020-03-14_23-35-16.webm 

  
  Could you investigate?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27958

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:85f646eb5649: [SystemTray] Fix item size for very narrow 
panel (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27958?vs=77321=77370

REVISION DETAIL
  https://phabricator.kde.org/D27958

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Konrad Materka]

kmaterka added a comment.


  In D27958#625431 , @broulik wrote:
  
  > Not sure if it is just me but the vertical alignment looks slightly off
  >  F8169131: Screenshot_20200310_172654.PNG 

  >  Or maybe that's the random different sizes
  
  
  This is just an illusion. I checked and literally counted pixels, centers of 
icons are aligned (both horizonaly and vertically). "de" icon is visually 
"heavier" at the bottom, the arrow on the right is heavier on top which makes 
impresion that these two are not aligned.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27958

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Nathaniel Graham]

ngraham added a comment.


  Nice, drag-and-drop now correctly shows the menu for the case of dragging an 
icon from Kickoff or the task manager. However dragging a URL still doesn't 
show the menu; it just downloads the entire page. We need the drop menu in this 
case because it's probably more common to want to create a link to the page 
than it is to download the entire thing.
  
  If introspecting the mimetype of every URL is too costly, could we maybe 
short-circuit the logic if the URL scheme is HTTP or HTTPS?
  
  Also I notice that the cursor still shows a plus sign icon when dragging a 
local file, even though it will be moved, not copied.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27958

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Kai Uwe Broulik]

broulik added a comment.


  Not sure if it is just me but the vertical alignment looks slightly off
  F8169131: Screenshot_20200310_172654.PNG 

  Or maybe that's the random different sizes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27958

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Konrad Materka]

kmaterka added a comment.


  I don't like how icon size and item size (container = icon + padding) are 
calculated and used... Firstly best icons size is calculated, but then padding 
are added. This combined size is used as item size (container size):
  
  - SNI icons are rounded to nearest icon size (implicitly, because  
PlasmaCore.IconItem is used)
  - Plasmoids are scaled to the size of the container, I don't know exactly how 
it work, probably because default compact representation is just an icon.
  
  By happy coincident it is (?) working correctly for all sizes.
  
  There is also a lot of anchoring involved, all items are aligned to left 
(which looks bad with expander arrow, gap is bigger) etc. But all of this can 
be fixed in separate patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27958

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27958: [SystemTray] Fix item size for very narrow panel

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  For very narrow panel item size is too big (item + paddings exceed panel 
size). This adds a check to not exceed poanel size.

TEST PLAN
  - Make panel very narrow - icons should fit into panel
  - Repeat for vertical/horizontal

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27958

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart