D27979: Added top area to notifications

2020-03-11 Thread Kai Uwe Broulik 
broulik added a comment.


  Please also test with icons and configure button, I use 
https://tests.peter.sh/notification-generator/ which can generate a multitude 
of test notifications

INLINE COMMENTS

> NotificationPopup.qml:168
>  // let the item bleed into the dialog margins so the close 
> button margins cancel out
> -y: closable || dismissable || configurable ? 
> -notificationPopup.margins.top : 0
> +y: closable || dismissable || configurable ? 
> -math.round(notificationPopup.margins.top / 2) : 0
>  headingRightPadding: -notificationPopup.margins.right

You know I'm not a fan of randomly dividing sizes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27979

To: niccolove, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27979: Added top area to notifications

2020-03-11 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Added the new PlasmoidHeading component to notifications, see:
  (...)
  This also adds it to the notifications in the history, which is not wanted.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_toparea

REVISION DETAIL
  https://phabricator.kde.org/D27979

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart