D27985: Include s_kcrashErrorMessage in our traces
broulik added a comment. When this symbol isn't present, gdb just aborts and you don't get any back trace anymore: Error in sourced command file: No symbol "s_kcrashErrorMessage" in current context. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D27985 To: apol, #frameworks, sitter Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27985: Include s_kcrashErrorMessage in our traces
This revision was automatically updated to reflect the committed changes. Closed by commit R871:39ed9cf6449e: Include s_kcrashErrorMessage in our traces (authored by apol). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27985?vs=77452=77676 REVISION DETAIL https://phabricator.kde.org/D27985 AFFECTED FILES src/data/debuggers/internal/gdbrc src/data/debuggers/internal/lldbrc src/tests/crashtest/crashtest.cpp To: apol, #frameworks, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27985: Include s_kcrashErrorMessage in our traces
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM for when the kcrash diff is ready. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27985 To: apol, #frameworks, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27985: Include s_kcrashErrorMessage in our traces
apol updated this revision to Diff 77452. apol added a comment. Include a usage in the test app, adapt to changes in kcrash REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27985?vs=77424=77452 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27985 AFFECTED FILES src/data/debuggers/internal/gdbrc src/data/debuggers/internal/lldbrc src/tests/crashtest/crashtest.cpp To: apol, #frameworks, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27985: Include s_kcrashErrorMessage in our traces
sitter added a comment. Probably should also get added to one of the parser tests to make sure it doesn't fall on the face. Talking about parser, I feel like this might benefit from highlighting somehow, currently it's very squished in with the random stuff in the header. That'll make it hard to search bugzilla for, globally, but also across different errors within the same application, as the only identifying element is `$1` and I'm sure that's profoundly ambiguous as a search term. Admittedly the only way to improve it I can think of is `print "Content of s_kcrashErrorMessage:"\nprint s_kcrashErrorMessage\n"`. The fact that this also prints empty messages doesn't exactly fill me with joy but I have no input on how to improve it either. Application: dragon (dragon), signal: Segmentation fault Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". $1 = "!!! HALLO THIS IS A MESSAGE !!", '\000' [Current thread is 1 (Thread 0x7f255f320880 (LWP 19076))] Thread 18 (Thread 0x7f250cff9700 (LWP 19093)): #0 0x7f255628d9f3 in futex_wait_cancelable (private=, expected=0, futex_word=0x2544640) at ../sysdeps/unix/sysv/linux/futex-internal.h:88 #1 __pthread_cond_wait_common (abstime=0x0, mutex=0 REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D27985 To: apol, #frameworks, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27985: Include s_kcrashErrorMessage in our traces
apol created this revision. apol added reviewers: Frameworks, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY CCBUG: 375913 TEST PLAN Called `kill -SIGSEGV plasma-discover` and got to see the string I passed. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27985 AFFECTED FILES src/data/debuggers/internal/gdbrc src/data/debuggers/internal/lldbrc To: apol, #frameworks, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
