D28024: [Baloo KCM] Expose "Index hidden" config setting
This revision was automatically updated to reflect the committed changes. Closed by commit R119:491ce0f1d78f: [Baloo KCM] Expose Index hidden config setting (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28024?vs=77558=77662 REVISION DETAIL https://phabricator.kde.org/D28024 AFFECTED FILES kcms/baloo/package/contents/ui/main.qml To: bruns, #baloo, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28024: [Baloo KCM] Expose "Index hidden" config setting
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, let's go for it as-is. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28024 To: bruns, #baloo, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28024: [Baloo KCM] Expose "Index hidden" config setting
bruns added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:59 > Instead adding these new layouts, you could just set the following on each > checkbox that needs to be indented: > > Layout.leftMargin: !LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : > 0 > Layout.rightMargin: LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : > 0 > > IMO that's a bit cleaner. The effect would be different, as currently there already is some margin. Also, this has to be repeated for each item, and I plan to add (at least) one more option. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28024 To: bruns, #baloo, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28024: [Baloo KCM] Expose "Index hidden" config setting
ngraham added inline comments.
INLINE COMMENTS
> main.qml:59
> +
> +ColumnLayout {
> +QQC2.CheckBox {
Instead adding these new layouts, you could just set the following on each
checkbox that needs to be indented:
Layout.leftMargin: !LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : 0
Layout.rightMargin: LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : 0
IMO that's a bit cleaner.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D28024
To: bruns, #baloo, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28024: [Baloo KCM] Expose "Index hidden" config setting
bruns created this revision. bruns added reviewers: Baloo, VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Also inset both "Index file content" and "Index hidden" so it is more obvious both are subordinate to the global "Enable indexing". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28024 AFFECTED FILES kcms/baloo/package/contents/ui/main.qml To: bruns, #baloo, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
