D28055: Fix on wayland activating minimized window will move window to current desktop

[Vlad Zahorodnii]

zzag added a comment.


  Yes, on Wayland, a window can be more on than just one desktop. However, in 
this scenario, the minimized window should not be placed on other desktops.
  
  > how should I proceed ?
  
  First, we need to make sure that plasmashell doesn't put the window on other 
desktops. We could do that by running WAYLAND_DEBUG=1 plasmashell and then 
analyzing the output. If plasmashell indeed doesn't place the window on other 
desktops, put some qDebugs in KWin to see where things go wrong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28055

To: pereira.alex, #plasma, zzag
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28055: Fix on wayland activating minimized window will move window to current desktop

[Alexandre Pereira]

pereira.alex added a comment.


  In D28055#628705 , @zzag wrote:
  
  > > it will put window to VD1 and VD2.
  >
  > It seems to me like this bug must be fixed in KWin rather than the task 
manager.
  
  
  In what I understand, wayland allows to specify in with virtual desktops 
windows can be, in contrast with x11, which a windows is on one virtual desktop 
or all of them. Is this correct ?
  
  zzag how should I proceed ? I don't know much about KWin source code, but if 
I may be of help, this could be a good way to start !

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28055

To: pereira.alex, #plasma, zzag
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28055: Fix on wayland activating minimized window will move window to current desktop

[Vlad Zahorodnii]

zzag added a comment.


  > it will put window to VD1 and VD2.
  
  It seems to me like this bug must be fixed in KWin rather than libtaskmanager.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28055

To: pereira.alex, #plasma, zzag
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28055: Fix on wayland activating minimized window will move window to current desktop

[Nathaniel Graham]

ngraham added a reviewer: zzag.
ngraham added a comment.


  Thanks for the patch! In general, don't comment out code, just remove the 
lines instead. Also if this fixes, 417888, add `BUG: 417888` on its own line 
somewhere in the description section of this patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28055

To: pereira.alex, #plasma, zzag
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28055: Fix on wayland activating minimized window will move window to current desktop

[Alexandre Pereira]

pereira.alex created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pereira.alex requested review of this revision.

REVISION SUMMARY
  As reported on bug #417888, on wayland if a window is minimized
  on VD1 and clicked to activate on VD2, it will put window
  to VD1 and VD2.
  By not calling the activate on minimized windows, it will fix this behaviour.
  ( I think this only happens on wayland because only on wayland you can put 
windows
  on VD1 and VD2 but not VDX, meaning not on all desktops )
  
  I tested this on X11 and Wayland, and everything seems to be working 
correctly.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-taskmanager-minimized-windows-virtual-desktops-bug (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28055

AFFECTED FILES
  applets/taskmanager/package/contents/ui/code/tools.js

To: pereira.alex
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart