D28066: Remove the STATIC_LIBRARY option to fix static builds

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:989cd3098ced: Remove the STATIC_LIBRARY option to fix 
static builds (authored by bartoc, committed by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28066?vs=79439=79440

REVISION DETAIL
  https://phabricator.kde.org/D28066

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: bartoc, #kirigami, apol
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D28066: Remove the STATIC_LIBRARY option to fix static builds

[Charles Barto]

bartoc updated this revision to Diff 79439.
bartoc added a comment.


  rebased on master

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28066?vs=78262=79439

REVISION DETAIL
  https://phabricator.kde.org/D28066

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: bartoc, #kirigami, apol
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D28066: Remove the STATIC_LIBRARY option to fix static builds

[Charles Barto]

bartoc added a comment.


  Can I get any more feedback on this? what do I have to do to get it merged?

REVISION DETAIL
  https://phabricator.kde.org/D28066

To: bartoc, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D28066: Remove the STATIC_LIBRARY option to fix static builds

[Charles Barto]

bartoc updated this revision to Diff 78262.
bartoc added a comment.


  Made setting STATIC_LIBRARY a fatal error.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28066?vs=77694=78262

REVISION DETAIL
  https://phabricator.kde.org/D28066

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: bartoc, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D28066: Remove the STATIC_LIBRARY option to fix static builds

[Charles Barto]

bartoc added a comment.


  In D28066#628195 , @apol wrote:
  
  > Makes sense to me. +1
  >
  > Since most people who did static builds will be using STATIC_LIBRARY, can 
you set a fatal error if it's on, so the devs know to use BUILD_SHARED_LIBS 
instead?
  
  
  Allright. I'm also looking into making a plugin target get installed so you 
can link against kirigamiplugin.lib in cmake.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28066

To: bartoc, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D28066: Remove the STATIC_LIBRARY option to fix static builds

[Aleix Pol Gonzalez]

apol added a comment.


  Makes sense to me. +1
  
  Since most people who did static builds will be using STATIC_LIBRARY, can you 
set a fatal error if it's on, so the devs know to use BUILD_SHARED_LIBS instead?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28066

To: bartoc, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D28066: Remove the STATIC_LIBRARY option to fix static builds

[Charles Barto]

bartoc created this revision.
bartoc added a reviewer: Kirigami.
bartoc added a project: Kirigami.
Herald added a subscriber: plasma-devel.
bartoc requested review of this revision.

REVISION SUMMARY
  Previously static builds were broken because
  GenerateExportHeader used:
  get_property(type TARGET ${TARGET_LIBRARY} PROPERTY TYPE)
  which returns STATIC_LIBRARY, however since we had an
  option of the same name that variable was "dobule expanded"
  in if statements, breaking GenerateExportHeader's logic
  
  Additionally remove the legacy style elseif(...) and endif(...) form
  conditionals
  
  fixes https://bugs.kde.org/show_bug.cgi?id=418905

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28066

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: bartoc, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart