D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

2020-03-17 Thread Mikhail Zolotukhin 
gikari updated this revision to Diff 77860.
gikari edited the summary of this revision.
gikari added a comment.


  - Remove the recolor module. It is D28076 
 now

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=77855=77860

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

2020-03-17 Thread Carson Black 
cblack added a comment.


  In D28072#629448 , @gikari wrote:
  
  > In D28072#629441 , @cblack wrote:
  >
  > > In D28072#629439 , @gikari 
wrote:
  > >
  > > > > You simply test the recolouration like how it's been up until 
now—restart the applications.
  > > >
  > > > It doesn't work. This is what I was talking about:
  > > >
  > > > > It seems like it applies randomly whenever the GTK app would like to 
update the colors, but with that module it's predictable.
  > >
  > >
  > > You seem to be testing with Nautilus, which doesn't actually close when 
you press the close button.
  >
  >
  > Yes, you're right, but I also tested it with Lutris. It also does not work. 
But with gedit it works fine.
  
  
  Lutris is also another application that doesn't close fully when you press 
close (however, that part is configurable in Lutris.)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

2020-03-17 Thread Mikhail Zolotukhin 
gikari added a comment.


  In D28072#629441 , @cblack wrote:
  
  > In D28072#629439 , @gikari wrote:
  >
  > > > You simply test the recolouration like how it's been up until 
now—restart the applications.
  > >
  > > It doesn't work. This is what I was talking about:
  > >
  > > > It seems like it applies randomly whenever the GTK app would like to 
update the colors, but with that module it's predictable.
  >
  >
  > You seem to be testing with Nautilus, which doesn't actually close when you 
press the close button.
  
  
  Yes, you're right, but I also tested it with Lutris. It also does not work. 
But with gedit it works fine.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

2020-03-17 Thread Carson Black 
cblack added a comment.


  In D28072#629439 , @gikari wrote:
  
  > > You simply test the recolouration like how it's been up until now—restart 
the applications.
  >
  > It doesn't work. This is what I was talking about:
  >
  > > It seems like it applies randomly whenever the GTK app would like to 
update the colors, but with that module it's predictable.
  
  
  You seem to be testing with Nautilus, which doesn't actually close when you 
press the close button.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

2020-03-17 Thread Mikhail Zolotukhin 
gikari added a comment.


  > You simply test the recolouration like how it's been up until now—restart 
the applications.
  
  It doesn't work. This is what I was talking about:
  
  > It seems like it applies randomly whenever the GTK app would like to update 
the colors, but with that module it's predictable.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

2020-03-17 Thread Carson Black 
cblack added a comment.


  In D28072#629425 , @gikari wrote:
  
  > - I should add the recoloration module to autoload with GTK applications
  >
  > In D28072#629422 , @cblack wrote:
  >
  > > The GTK+ module shouldn't be in this patch, as it and the functions to 
write CSS are separate changes.
  >
  >
  > Then how do I test the recoloration? It seems like it applies randomly 
whenever the GTK app would like to update the colors, but with that module it's 
predictable. Or do you mean to make it as a separate patch, but make this one 
depend on it?
  
  
  The two items don't have a dependency relation codewise. You simply test the 
recolouration like how it's been up until now—restart the applications.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

2020-03-17 Thread Mikhail Zolotukhin 
gikari planned changes to this revision.
gikari added a comment.


  - I should add the recoloration module to autoload with GTK applications
  
  In D28072#629422 , @cblack wrote:
  
  > The GTK+ module shouldn't be in this patch, as it and the functions to 
write CSS are separate changes.
  
  
  Then how do I test the recoloration? It seems like it applies randomly 
whenever the GTK app would like to update the colors, but with that module it's 
predictable. Or do you mean to make it as a separate patch, but make this one 
depend on it?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

2020-03-17 Thread Carson Black 
cblack requested changes to this revision.
cblack added a comment.
This revision now requires changes to proceed.


  The GTK+ module shouldn't be in this patch, as it and the functions to write 
CSS are separate changes.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

2020-03-17 Thread Mikhail Zolotukhin 
gikari updated this revision to Diff 77855.
gikari added a comment.


  - Rebase on master
  - Add recoloration module

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=77723=77855

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

2020-03-16 Thread Mikhail Zolotukhin 
gikari added inline comments.

INLINE COMMENTS

> configeditor.cpp:107
> +modifyColorsCssFile(colorsDefinitions);
> +// FIXME Find a way to update colors on the fly
> +}

Also, I would like to move D24275  to 
kde-gtk-config repo too with autoloading the module to all GTK applications.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart