D28086: Improve CMake handling of GNOME libraries

2020-03-29 Thread Mikhail Zolotukhin 
gikari added a comment.


  Everything is fine on CI.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-29 Thread Carson Black 
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:7f7a57095cf1: Improve CMake handling of GNOME libraries 
(authored by cblack).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28086?vs=78590=78803

REVISION DETAIL
  https://phabricator.kde.org/D28086

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGTK3.cmake
  gtk3proxies/CMakeLists.txt
  gtkproxies/CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-27 Thread Mikhail Zolotukhin 
gikari accepted this revision.
gikari added a comment.
This revision is now accepted and ready to land.


  Ok, let's keep our eyes on CI now. Everything should be fine, since the 
dependencies didn't change.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  arcpatch-D28086

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-26 Thread Carson Black 
cblack updated this revision to Diff 78590.
cblack added a comment.


  Drop giomm

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28086?vs=77833=78590

BRANCH
  arcpatch-D28086

REVISION DETAIL
  https://phabricator.kde.org/D28086

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGTK3.cmake
  gtk3proxies/CMakeLists.txt
  gtkproxies/CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-23 Thread Mikhail Zolotukhin 
gikari added inline comments.

INLINE COMMENTS

> CMakeLists.txt:22
> +pkg_check_modules(GIO REQUIRED IMPORTED_TARGET gio-2.0)
> +pkg_check_modules(giomm REQUIRED IMPORTED_TARGET giomm-2.4)
> +

If I understand correctly this line is redundant.

> CMakeLists.txt:7
>  target_compile_definitions(gtk_preview PRIVATE 
> "-DDATA_DIR=\"${KDE_INSTALL_FULL_DATADIR}/kcm-gtk-module/\"")
> -target_link_libraries(gtk_preview ${GTK2_LIBRARIES} ${GTK2_GIOMM_LIBRARY})
> +target_link_libraries(gtk_preview PkgConfig::GTK+2 PkgConfig::giomm)
>  install(TARGETS gtk_preview RUNTIME DESTINATION "${LIBEXEC_INSTALL_DIR}")

And `PkgConfig::giomm` is redundant too.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-23 Thread Mikhail Zolotukhin 
gikari added a comment.


  See https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/49 for 
possible resolution

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-21 Thread Mikhail Zolotukhin 
gikari added a comment.


  This has been reverted. @cblack, please take a look 

 at what has happened. Seems like CI is missing some dependency.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-17 Thread Carson Black 
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:db87b4d270a1: Improve CMake handling of GNOME libraries 
(authored by cblack).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28086?vs=77831=77833

REVISION DETAIL
  https://phabricator.kde.org/D28086

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGTK3.cmake
  gtk3proxies/CMakeLists.txt
  gtkproxies/CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-17 Thread Mikhail Zolotukhin 
gikari accepted this revision.
gikari added a comment.
This revision is now accepted and ready to land.


  Fine.  It builds.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-17 Thread Carson Black 
cblack added a comment.


  In D28086#628957 , @gikari wrote:
  
  > It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` 
module? It actually uses it inside already, but with some bugs, that prevents 
from building last patch.
  
  
  It's a lot of CMake code that duplicates what CMake already offers with its 
pkgconf handling. There's no reason to use it when CMake can wrangle that stuff 
for you.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-17 Thread Carson Black 
cblack updated this revision to Diff 77831.
cblack added a comment.


  Rebase on master for reverted commits

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28086?vs=77790=77831

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGTK3.cmake
  gtk3proxies/CMakeLists.txt
  gtkproxies/CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-17 Thread Mikhail Zolotukhin 
gikari requested changes to this revision.
gikari added a comment.
This revision now requires changes to proceed.


  I reverted the commits ( R99:306e01d86ab9a891ec70219802ce01572b0d4025 
 and 
R99:306e01d86ab9a891ec70219802ce01572b0d4025 
 ) 
for recoloration module, to fix the CI. I think you need to create a new 
revision to add recolaration module in a proper way and with proper fixes to 
GNOME libraries handling.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-17 Thread Mikhail Zolotukhin 
gikari added a comment.


  It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` 
module? It actually uses it inside already, but with some bugs, that prevents 
from building last patch.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-16 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Good stuff!

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

2020-03-16 Thread Carson Black 
cblack created this revision.
cblack added reviewers: Plasma, gikari.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  GNOME libraries were being handled in a manner not
  as elegant as possible with CMake's built-in pkgconf handling.
  This patch uses CMake's built-in pkgconf handling to trim excess
  code and improve style (${GTK_LIBRARIES} -> PkgConfig::GTK+3).

TEST PLAN
  See that everything still builds and links as expected.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGTK3.cmake
  color-reload-module/CMakeLists.txt
  gtk3proxies/CMakeLists.txt
  gtkproxies/CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt

To: cblack, #plasma, gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart