D28103: introduce PassiveNotification type

[Marco Martin]

mart updated this revision to Diff 77934.
mart added a comment.


  - export the item
  - support multiple notifications
  - make it a private component again
  - fix passive notifications for ApplciationItem

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28103?vs=77901=77934

BRANCH
  mart/passivenotification

REVISION DETAIL
  https://phabricator.kde.org/D28103

AFFECTED FILES
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/qmldir

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28103: introduce PassiveNotification type

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:4e596d8bed9c: introduce PassiveNotification type 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28103?vs=77843=77901#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28103?vs=77843=77901

REVISION DETAIL
  https://phabricator.kde.org/D28103

AFFECTED FILES
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/PassiveNotification.qml
  src/controls/templates/PassiveNotification.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/qmldir

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28103: introduce PassiveNotification type

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> PassiveNotification.qml:18
> +notifications in the app.
> + * used to show messages of limited importance that make sense only when
> + * the user is using the application and wouldn't be suited as a global 

`messages of limited importance` -> maybe something a bit more explicit like 
`transient, ignorable status messages of limited importance`

> PassiveNotification.qml:21
> + * system-wide notification.
> + * This is not a full-fledged notification system. the applciation should 
> + * use this with care and only one notification should be visible at once 
> per app.

`the applciation` -> `The application`

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28103: introduce PassiveNotification type

[Marco Martin]

mart added a comment.


  In D28103#629313 , @ngraham wrote:
  
  > Didn't this already exist in Kirigami, or am I imagining that?
  
  
  there is ApplicationWindow.showPassiveNotification.
  it was only accessible by that (and not accessible by kcms) this makes it an 
instatiable component
  
  look and features stay the same

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28103: introduce PassiveNotification type

[Nathaniel Graham]

ngraham added a comment.


  Didn't this already exist in Kirigami, or am I imagining that?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28103: introduce PassiveNotification type

[Marco Martin]

mart added a comment.


  One thing I'm not sure of is whether going this way, with one popup that 
shows only one notification or having a popup with a listview that can show 
multiple notifications at once...
  tough for me an important thing is that this thing does *-NOT* become a full 
fledged notification system

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28103: introduce PassiveNotification type

[Marco Martin]

mart updated this revision to Diff 77843.
mart added a comment.


  - export the item

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28103?vs=77842=77843

BRANCH
  mart/passivenotification

REVISION DETAIL
  https://phabricator.kde.org/D28103

AFFECTED FILES
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/PassiveNotification.qml
  src/controls/templates/PassiveNotification.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/qmldir
  src/kirigamiplugin.cpp
  src/qmldir

To: mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28103: introduce PassiveNotification type

[Marco Martin]

mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  PassiveNotification is a type for small, passive and inline
  notifications in the app.
  used to show messages of limited importance that make sense only when
  the user is using the application and wouldn't be suited as a global
  system-wide notification.
  This is not a full-fledged notification system. the applciation should
  use this with care and only one notification should be visible at once
  per app.

TEST PLAN
  it looks and behaves the same as ApplicationWindow.showPassiveNotification 
  (which now uses it) as well standalone notification items work.

REPOSITORY
  R169 Kirigami

BRANCH
  mart/passivenotification

REVISION DETAIL
  https://phabricator.kde.org/D28103

AFFECTED FILES
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/PassiveNotification.qml
  src/controls/templates/PassiveNotification.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/qmldir

To: mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart