D28141: Add KSysGuard::Sensors library

2020-05-07 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:5cfc09fd4463: Add KSysGuard::Sensors library (authored by 
ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=82082=82181

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma, davidedmundson
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-05-06 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 82082.
ahiemstra added a comment.


  Maybe right now?

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=82081=82082

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-05-06 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 82081.
ahiemstra added a comment.


  Urgh arc

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=82080=82081

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-05-06 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 82080.
ahiemstra added a comment.


  - Correct Vlad's name in a few more places
  - Make comments in SensorInfo_p.h a bit more useful

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=81577=82080

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-05-04 Thread Nathaniel Graham
ngraham added a comment.


  +1, excellent work.

INLINE COMMENTS

> Sensor.cpp:2
> +/*
> +Copyright (C) 2019 Vlad Zagorodniy 
> +Copyright (C) 2020 Arjen Hiemstra 

Update name

> Sensor.cpp:219
> +
> +if(parent() && parent()->metaObject()->indexOfSignal("enabledChanged()") 
> != -1) {
> +connect(parent(), SIGNAL(enabledChanged()), this, 
> SIGNAL(enabledChanged()));

`if (`

> SensorInfo_p.h:36
> +SensorInfo() = default;
> +QString name; //translated?
> +QString shortName; // translated

Is it? :)

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28141

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-04-30 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 81577.
ahiemstra added a comment.


  Don't eat the lib Arc

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=81576=81577

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Unit.h
  processcore/formatter.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-04-30 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 81576.
ahiemstra added a comment.


  - Don't expose private SensorInfo in public interface of SensorQuery

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=80758=81576

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorQuery.h
  sensors/declarative/CMakeLists.txt

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-04-21 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 80758.
ahiemstra added a comment.


  - clang-format sensors lib
  - Capture this rather than =

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=79072=80758

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Unit.h
  processcore/formatter.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-04-21 Thread Arjen Hiemstra
ahiemstra added inline comments.

INLINE COMMENTS

> mart wrote in SensorsPlugin.cpp:2
> also here

Same issue as above.

> mart wrote in SensorsPlugin.h:2
> shouldn't remove existing copyrights?

It's a new file, but for some reason Phab thinks it's copied from formatter.h 
(which it has nothing to do with).

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28141

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-04-21 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> Sensor.cpp:207
> +
> +if(parent() && parent()->metaObject()->indexOfSignal("enabledChanged()") 
> != -1) {
> +connect(parent(), SIGNAL(enabledChanged()), this, 
> SIGNAL(enabledChanged()));

if (

> SensorDaemonInterface.cpp:87
> +auto watcher = new 
> QDBusPendingCallWatcher{d->dbusInterface->sensorData({sensorId}), this};
> +connect(watcher, ::finished, watcher, 
> [=](QDBusPendingCallWatcher *self) {
> +self->deleteLater();

also here, [this] instead of [=]

> SensorsPlugin.cpp:2
>  /*
> -Copyright (C) 2019 Vlad Zagorodniy 
> +Copyright (C) 2020 Arjen Hiemstra 
>  

also here

> SensorsPlugin.h:2
>  /*
> -Copyright (C) 2019 Vlad Zagorodniy 
> +Copyright (C) 2020 Arjen Hiemstra 
>  

shouldn't remove existing copyrights?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28141

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-04-01 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 79072.
ahiemstra added a comment.


  - Fix qmldir file

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78985=79072

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Unit.h
  processcore/formatter.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-04-01 Thread Marco Martin
mart added a comment.


  while porting the systemmonitor plasmoids to upstream, i found a couple of 
problems:
  
  - gcc didn't like inserting using a const iterator
  - qmldir outdated with the old plugin name
  
  diff on top of this phab: https://phabricator.kde.org/P567

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28141

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra


D28141: Add KSysGuard::Sensors library

2020-03-31 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 78985.
ahiemstra added a comment.


  - Update zzag's last name

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78372=78985

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Unit.h
  processcore/formatter.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28141: Add KSysGuard::Sensors library

2020-03-24 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 78372.
ahiemstra added a comment.


  - Add some documentation to classes
  - Properly install the export header
  - Don't use PUBLIC_HEADERS, it's not well supported on earlier CMake
  - Rebase, update SensorInfo and Daemon XML to new versions

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78275=78372

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28141: Add KSysGuard::Sensors library

2020-03-23 Thread Vlad Zahorodnii
zzag added inline comments.

INLINE COMMENTS

> Sensor.h:2
> +/*
> +Copyright (C) 2019 Vlad Zagorodniy 
> +Copyright (C) 2020 Arjen Hiemstra 

Could you please update my last name?

  git grep -l 'Vlad Zagorodniy' | xargs sed -i 's/Vlad Zagorodniy/Vlad 
Zahorodnii/g'

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28141

To: ahiemstra, #plasma
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28141: Add KSysGuard::Sensors library

2020-03-23 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 78275.
ahiemstra added a comment.


  - Don't use PUBLIC_HEADERS, it's not well supported on earlier CMake

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78080=78275

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28141: Add KSysGuard::Sensors library

2020-03-20 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 78080.
ahiemstra added a comment.


  - Properly install the export header

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78020=78080

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28141: Add KSysGuard::Sensors library

2020-03-19 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 78020.
ahiemstra added a comment.


  - Add some documentation to classes

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78017=78020

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28141: Add KSysGuard::Sensors library

2020-03-19 Thread Arjen Hiemstra
ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a new library for communicating with a new KSysGuard
  DBus-based daemon that provides sensors. The daemon will be
  posted by d_ed later on.
  
  This new library pretty much maps the different objects from
  the daemon to C++ objects.

TEST PLAN
  None yet, needs the new daemon.

REPOSITORY
  R111 KSysguard Library

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart