D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Alexander Lohnau]

alex abandoned this revision.
alex added a comment.


  Is handled in separate patches.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28196

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  This should be 3 submission:
  
  1. early return/indentation changes (preparation)
  2. always read default profile from FF config, do not write "dbfile" to 
runner config
  3. fix lookup of default  profile name

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28196

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Stefan Brüns]

bruns added a comment.


  Also keep code lines at < 80 characters

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28196

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Stefan Brüns]

bruns added a comment.


  Regarding the summary:
  
  1. Wrap the lines at <80 characters
  2. Describe the screenshot textually

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28196

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Stefan Brüns]

bruns added a comment.


  Can you split out the early-return part for the QSQLite driver and submit it 
as a preparation patch?
  
  It adds quite some noise to the diff due to the whitespace changes (though I 
fully agree it is the better coding pattern).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28196

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Alexander Lohnau]

alex updated this revision to Diff 78205.
alex added a comment.


  Add check if profilePath is empty

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28196?vs=78204&id=78205

BRANCH
  bookmarks_firefox_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28196

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Alexander Lohnau]

alex created this revision.
alex added reviewers: bruns, z3ntu, apol, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Before this patch the path to the default profile database was once read and 
then written in the config. And as long as this file exists this value would be 
used. But if the user changes the default profile in Firefox the old profile 
will still be used (as long as it is not deleted).
  
  And the default profile was also not always correctly extracted (this 
configuration got only edited in the about:profiles page in Firefox):
  F8192502: BugfixDoc 

TEST PLAN
  Test if the bookmarks are correctly displayed (with a single profile), add a 
new profile and restart KRunner, set the default profile back to the old 
profile and restart KRunner.
  The bookmarks should always be displayed.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bookmarks_firefox_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28196

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, bruns, z3ntu, apol, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart