D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob
broulik planned changes to this revision. broulik added a comment. I'll look into creating a `KNotificationUiDelegate` or something along the lines REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 To: broulik, #plasma, hein, dfaure Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob
dfaure added inline comments. INLINE COMMENTS > backend.cpp:178 > +auto *job = new KIO::ApplicationLauncherJob(service, > serviceAction); > +// TODO uidelegate > +job->start(); Only if you like messageboxes. Plasma code might prefer something else? A notification maybe? I think we both know a guy who likes them very much ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 To: broulik, #plasma, hein, dfaure Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28286: WIP: [Task Manager] Port backend to ApplicationLauncherJob
broulik created this revision. broulik added reviewers: Plasma, hein, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In the process, port jump list actions from custom `KDesktopFile` parsing to `KServiceAction` on `KService`, simplifying the code a lot. TEST PLAN - I do need this UI delegate, right? - Launching incognito tabs in my browser still works - Opening Dolphin places still works - Opening recent docs still work and do open in the app the task manager entry is for rather than the default app for the mimetype REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 AFFECTED FILES applets/taskmanager/plugin/backend.cpp applets/taskmanager/plugin/backend.h To: broulik, #plasma, hein, dfaure Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
