D28314: Allow setting separate corner radii for ShadowedRectangle
This revision was automatically updated to reflect the committed changes. Closed by commit R169:eb4e9064e7e4: Allow setting separate corner radii for ShadowedRectangle (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28314?vs=79075=79480 REVISION DETAIL https://phabricator.kde.org/D28314 AFFECTED FILES src/controls/ShadowedImage.qml src/kirigamiplugin.cpp src/scenegraph/shaders/shadowedborderrectangle.frag src/scenegraph/shaders/shadowedbordertexture.frag src/scenegraph/shaders/shadowedrectangle.frag src/scenegraph/shaders/shadowedtexture.frag src/scenegraph/shadowedrectanglematerial.h src/scenegraph/shadowedrectanglenode.cpp src/scenegraph/shadowedrectanglenode.h src/shadowedrectangle.cpp src/shadowedrectangle.h src/shadowedtexture.cpp src/shadowedtexture.h tests/ShadowedImageTest.qml tests/ShadowedRectangleTest.qml To: ahiemstra, #kirigami, mart Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
D28314: Allow setting separate corner radii for ShadowedRectangle
ahiemstra updated this revision to Diff 79075. ahiemstra added a comment. Rebase onto master, also support ShadowedTexture REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28314?vs=78574=79075 BRANCH shadowedrect_separatecorners REVISION DETAIL https://phabricator.kde.org/D28314 AFFECTED FILES src/controls/ShadowedImage.qml src/kirigamiplugin.cpp src/scenegraph/shaders/shadowedborderrectangle.frag src/scenegraph/shaders/shadowedbordertexture.frag src/scenegraph/shaders/shadowedrectangle.frag src/scenegraph/shaders/shadowedtexture.frag src/scenegraph/shadowedrectanglematerial.h src/scenegraph/shadowedrectanglenode.cpp src/scenegraph/shadowedrectanglenode.h src/shadowedrectangle.cpp src/shadowedrectangle.h src/shadowedtexture.cpp src/shadowedtexture.h tests/ShadowedImageTest.qml tests/ShadowedRectangleTest.qml To: ahiemstra, #kirigami Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
D28314: Allow setting separate corner radii for ShadowedRectangle
broulik added a comment. Cool INLINE COMMENTS > shadowedrectangle.h:157 > +private: > +float m_topLeft = -1.0; > +float m_topRight = -1.0; How about using NaN to define "not set"? though you can't have negative radius, so probably fine REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28314 To: ahiemstra, #kirigami Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
D28314: Allow setting separate corner radii for ShadowedRectangle
ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a "corners" grouped property that allows setting separate radii for the different corners of ShadowedRectangle. By default, these are ignored and instead the value of "radius" is used. TEST PLAN The manual test has been updated, it should look like this: REPOSITORY R169 Kirigami BRANCH shadowedrect_separatecorners REVISION DETAIL https://phabricator.kde.org/D28314 AFFECTED FILES src/kirigamiplugin.cpp src/scenegraph/shadowedborderrectangle.frag src/scenegraph/shadowedborderrectangle_core.frag src/scenegraph/shadowedrectangle.frag src/scenegraph/shadowedrectangle_core.frag src/scenegraph/shadowedrectanglematerial.h src/scenegraph/shadowedrectanglenode.cpp src/scenegraph/shadowedrectanglenode.h src/shadowedrectangle.cpp src/shadowedrectangle.h tests/ShadowedRectangleTest.qml To: ahiemstra, #kirigami Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
D28314: Allow setting separate corner radii for ShadowedRectangle
ahiemstra updated this revision to Diff 78574. ahiemstra added a comment. - Update test REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28314?vs=78573=78574 BRANCH shadowedrect_separatecorners REVISION DETAIL https://phabricator.kde.org/D28314 AFFECTED FILES src/kirigamiplugin.cpp src/scenegraph/shadowedborderrectangle.frag src/scenegraph/shadowedborderrectangle_core.frag src/scenegraph/shadowedrectangle.frag src/scenegraph/shadowedrectangle_core.frag src/scenegraph/shadowedrectanglematerial.h src/scenegraph/shadowedrectanglenode.cpp src/scenegraph/shadowedrectanglenode.h src/shadowedrectangle.cpp src/shadowedrectangle.h tests/ShadowedRectangleTest.qml To: ahiemstra, #kirigami Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
