D28347: Port services and shell runner away from KRun

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6e660cf92d7c: Port services and shell runner away from 
KRun (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28347?vs=78840&id=79455

REVISION DETAIL
  https://phabricator.kde.org/D28347

AFFECTED FILES
  runners/services/CMakeLists.txt
  runners/services/servicerunner.cpp
  runners/shell/CMakeLists.txt
  runners/shell/shellrunner.cpp

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28347: Port services and shell runner away from KRun

[Kai Uwe Broulik]

broulik updated this revision to Diff 78840.
broulik added a comment.


  - Adjust to API change in `KServiceAction`
  - Also don't use now deprecated `QUrl::queryItemValue`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28347?vs=78651&id=78840

REVISION DETAIL
  https://phabricator.kde.org/D28347

AFFECTED FILES
  runners/services/CMakeLists.txt
  runners/services/servicerunner.cpp
  runners/shell/CMakeLists.txt
  runners/shell/shellrunner.cpp

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28347: Port services and shell runner away from KRun

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Will rebase on pending API change in D28268 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28347

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28347: Port services and shell runner away from KRun

[David Faure]

dfaure added a comment.


  Looks good to me, but please wait until D28367 
 and D28268 
 land, since they change the API of 
ApplicationLauncherJob for KServiceAction.
  
  I do not think KActivities::ResourceInstance::notifyAccessed should be done 
from KIO, which doesn't depend on KActivities (and I would like to keep it that 
way).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28347

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28347: Port services and shell runner away from KRun

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Use `ApplicationLauncherJob` and `CommandLauncherJob`.
  Also, for services runner pass a `KServiceAction` to the job so it invokes 
the appropriate jump list action

TEST PLAN
  Depends on D28295 
  
  - Running normal programs still works
  - Invoking jump list action entries still works
  - Running programs with spaces in their desktop file (checking if that `QUrl` 
breaks some encoding) still works
  - Running shell commands still works
  - Running shell commands in terminal (unchanged) still works
  
  - When program fails to launch, I now get a nice plasma notification
  
  Makes me wonder if we should do the `notifyAccessed` stuff in the job as well?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28347

AFFECTED FILES
  runners/services/CMakeLists.txt
  runners/services/servicerunner.cpp
  runners/shell/CMakeLists.txt
  runners/shell/shellrunner.cpp

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart