D28389: Add support for logging categories
This revision was automatically updated to reflect the committed changes. Closed by commit R133:c103ceb1caf0: Add support for logging categories (authored by romangg). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28389?vs=78881=79092 REVISION DETAIL https://phabricator.kde.org/D28389 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt greeter/CMakeLists.txt greeter/greeterapp.cpp greeter/main.cpp ksldapp.cpp logind.cpp x11locker.cpp To: romangg, #plasma, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D28389: Add support for logging categories
romangg added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:23 > Make sure the include() call is before the add_subdirectory(). > > That's why we usually put them together on top right under the find_package() > together with `include(ECMGenerateHeaders)`. Put the include on top and the other trick was to just include the generated cpp file. Thanks. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28389 To: romangg, #plasma Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D28389: Add support for logging categories
romangg updated this revision to Diff 78881. romangg added a comment. Include the cpp files REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28389?vs=78765=78881 BRANCH logging-categories REVISION DETAIL https://phabricator.kde.org/D28389 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt greeter/CMakeLists.txt greeter/greeterapp.cpp greeter/main.cpp ksldapp.cpp logind.cpp x11locker.cpp To: romangg, #plasma Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D28389: Add support for logging categories
apol added a comment. Other than that, the patch looks good. +1 INLINE COMMENTS > romangg wrote in CMakeLists.txt:23 > Any idea how to reuse the declaration from the top-directory CMake file? Make sure the include() call is before the add_subdirectory(). That's why we usually put them together on top right under the find_package() together with `include(ECMGenerateHeaders)`. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28389 To: romangg, #plasma Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
D28389: Add support for logging categories
romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:23 > +Critical > +) > + Any idea how to reuse the declaration from the top-directory CMake file? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28389 To: romangg, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28389: Add support for logging categories
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Adds category logging to the KScreenLocker daemon/library and the greeter. Replaces all current uncategorized messages with categorized ones in these parts. TEST PLAN Tested messages with autotests and QT_LOGGING_RULES="kscreenlocker*=true". REPOSITORY R133 KScreenLocker BRANCH logging-categories REVISION DETAIL https://phabricator.kde.org/D28389 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt greeter/CMakeLists.txt greeter/greeterapp.cpp greeter/main.cpp ksldapp.cpp logind.cpp x11locker.cpp To: romangg, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
