D28428: [screenlocker] listen to notifications from the notification server

[Bhushan Shah]

bshah abandoned this revision.
bshah added a comment.


  Closed in favor of the more simpler version.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28428

To: bshah, davidedmundson
Cc: davidedmundson, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28428: [screenlocker] listen to notifications from the notification server

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  We've added a DBus interface to the screensaver host; ksmserver or kwin 
respectively.
  That receives the notification and then using a different API over wayland, 
sends it to the greeter.
  Is that right?
  
  Is so, why this extra complicated route?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28428

To: bshah, davidedmundson
Cc: davidedmundson, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28428: [screenlocker] listen to notifications from the notification server

[Bhushan Shah]

bshah updated this revision to Diff 78904.
bshah added a comment.


  - properly wire up the protocol for ksldapp to greeter

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28428?vs=78883=78904

BRANCH
  bshah/ksld-notifications

REVISION DETAIL
  https://phabricator.kde.org/D28428

AFFECTED FILES
  dbus/org.kde.screensaver.xml
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  interface.cpp
  interface.h
  protocols/ksld.xml
  waylandserver.cpp
  waylandserver.h

To: bshah
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28428: [screenlocker] listen to notifications from the notification server

[Bhushan Shah]

bshah updated this revision to Diff 78883.
bshah added a comment.


  - add argument for the notification id in dbus service
  - add wayland protocol stanza for passing notification data to greeter

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28428?vs=78872=78883

BRANCH
  bshah/ksld-notifications

REVISION DETAIL
  https://phabricator.kde.org/D28428

AFFECTED FILES
  dbus/org.kde.screensaver.xml
  interface.cpp
  interface.h
  protocols/ksld.xml

To: bshah
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28428: [screenlocker] listen to notifications from the notification server

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> interface.cpp:213
>  
> +void Interface::Notify(const QString& app_name, uint replaces_id, const 
> QString& app_icon,
> +   const QString& summary, const QString& body, const 
> QStringList& actions,

conding style: & after space

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28428

To: bshah
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28428: [screenlocker] listen to notifications from the notification server

[Bhushan Shah]

bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  This will allow notification manager to forward the notifications that
  are meant to be shown on the lockscreen, currently it requires patches
  in ksld wayland protocol and greeter to be useful, which is not part of
  this patch.

TEST PLAN
  tested with D28427 

REPOSITORY
  R133 KScreenLocker

BRANCH
  bshah/ksld-notifications

REVISION DETAIL
  https://phabricator.kde.org/D28428

AFFECTED FILES
  dbus/org.kde.screensaver.xml
  interface.cpp
  interface.h

To: bshah
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart