D28458: Bugfix ConverterRunner

2020-03-31 Thread Alexander Lohnau
alex added a comment.


  I don't know why but I cant land this patch(`arc land --preview` looks fine) 
and the previous commits worked:
  `fatal: remote error: service not enabled: /kdeplasma-addons`
  
  I would be thankful if you could commit this.

REPOSITORY
  R114 Plasma Addons

BRANCH
  converter_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28458

To: alex, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28458: Bugfix ConverterRunner

2020-03-31 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R114 Plasma Addons

BRANCH
  converter_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28458

To: alex, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28458: Bugfix ConverterRunner

2020-03-31 Thread Alexander Lohnau
alex created this revision.
alex added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Skip empty parts when splitting the units(D27166: Refactor converter runner 
).
  PS: I had to set the locale to german to reproduce this issue,
  thats why I didn't noticed it in the first place.

TEST PLAN
  Does not display results for queries like 1/2

REPOSITORY
  R114 Plasma Addons

BRANCH
  converter_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28458

AFFECTED FILES
  runners/converter/converterrunner.cpp

To: alex, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart