D28853: krunner: Prevent regression

2020-04-17 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a28e110cbb15: krunner: Prevent regression (authored by 
apol, committed by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28853?vs=80192&id=80371

REVISION DETAIL
  https://phabricator.kde.org/D28853

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: apol, #plasma, fvogt
Cc: fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28853: krunner: Prevent regression

2020-04-17 Thread Fabian Vogt
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Proper fix with refactoring will take too long, let's take this for now.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28853

To: apol, #plasma, fvogt
Cc: fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28853: krunner: Prevent regression

2020-04-15 Thread Aleix Pol Gonzalez
apol created this revision.
apol added a reviewer: Plasma.
apol added a project: Plasma.
apol requested review of this revision.

REVISION SUMMARY
  It was pointed out to me that using NoDisplay=true breaks starting
  krunner.
  
  Alternatively D24956  could be landed.

TEST PLAN
  Still works for me, for some reason

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28853

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart