D28914: Include the Plasma Vault name in the mount dialog title

[Nathaniel Graham]

ngraham added a comment.


  Landed on master since adding or changing strings in the stable branch isn't 
allowed.
  
  Thanks for the contribution!

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R845:6944aab19e86: Include the Plasma Vault name in the mount 
dialog title (authored by ksmanis, committed by ngraham).

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28914?vs=80455=80560

REVISION DETAIL
  https://phabricator.kde.org/D28914

AFFECTED FILES
  kded/ui/mountdialog.cpp
  kded/ui/mountdialog.ui

To: ksmanis, #plasma, davidedmundson, ivan, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Konstantinos Smanis]

ksmanis marked an inline comment as done.
ksmanis added inline comments.

INLINE COMMENTS

> ngraham wrote in mountdialog.cpp:34
> Maybe put the vault name in single quotes?

Agreed, I had single quotes initially, but wasn't sure if it was proper.

REPOSITORY
  R845 Plasma Vault

BRANCH
  password-manager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Konstantinos Smanis]

ksmanis updated this revision to Diff 80455.
ksmanis added a comment.


  - Add single quotes around the vault name

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28914?vs=80374=80455

BRANCH
  password-manager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28914

AFFECTED FILES
  kded/ui/mountdialog.cpp
  kded/ui/mountdialog.ui

To: ksmanis, #plasma, davidedmundson, ivan, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Nathaniel Graham]

ngraham added a comment.


  Go ahead, although we're migrating patch review to GitLab in the coming 
weeks, so the benefit may be short-lived. :)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Konstantinos Smanis]

ksmanis added a comment.


  In D28914#650523 , @ngraham wrote:
  
  > Can you provide your email address in a comment here so that we can land 
the patch with the correct git authorship information?
  
  
  I'd like to give arcanist a spin, if possible :)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Nathaniel Graham]

ngraham added a comment.


  Can you provide your email address in a comment here so that we can land the 
patch with the correct git authorship information?

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Nathaniel Graham]

ngraham added reviewers: ivan, VDG.
ngraham added inline comments.

INLINE COMMENTS

> mountdialog.cpp:34
>  m_ui.setupUi(this);
> +setWindowTitle(i18nc("%1 is the name of the Plasma Vault to open", "Open 
> %1 Plasma Vault", vault->name()));
>  

Maybe put the vault name in single quotes?

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

To: ksmanis, #plasma, davidedmundson, ivan, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28914: Include the Plasma Vault name in the mount dialog title

[Konstantinos Smanis]

ksmanis created this revision.
ksmanis added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ksmanis requested review of this revision.

REVISION SUMMARY
  Allows synergy with password managers that rely on the window title in order 
to supply the appropriate password.

TEST PLAN
  Compiles and runs as expected both on master and Plasma/5.18 branches.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28914

AFFECTED FILES
  kded/ui/mountdialog.cpp
  kded/ui/mountdialog.ui

To: ksmanis, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart