D28996: Converted to page and added heading

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:a876b365bb22: Converted to page and added heading 
(authored by niccolove).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28996?vs=80589=80940

REVISION DETAIL
  https://phabricator.kde.org/D28996

AFFECTED FILES
  applet/contents/ui/main.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28996: Converted to page and added heading

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All right.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28996

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28996: Converted to page and added heading

[Niccolò Venerandi]

niccolove added a comment.


  In D28996#652157 , @ngraham wrote:
  
  > Great! However the footer looks a bit weird since it doesn't touch the 
edges: F8247573: Screenshot_20200419_154306.png 

  
  
  True but it's unrelated to this patch - it's system tray cutting off 
everything that is outside of the applet container. I want to address that in 
another patch

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28996

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28996: Converted to page and added heading

[Nathaniel Graham]

ngraham added a comment.


  Great! However the footer looks a bit weird since it doesn't touch the edges: 
F8247573: Screenshot_20200419_154306.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28996

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28996: Converted to page and added heading

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  screenshots coming

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28996

AFFECTED FILES
  applet/contents/ui/main.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart