D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham 
ngraham closed this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham 
ngraham updated this revision to Diff 83066.
ngraham added a comment.


  Compute background color in a more colorscheme-friendly way

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29081?vs=83065=83066

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham 
ngraham updated this revision to Diff 83065.
ngraham added a comment.


  Fix non-rounded corners

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29081?vs=83064=83065

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham 
ngraham updated this revision to Diff 83064.
ngraham added a comment.


  Rebase

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29081?vs=80924=83064

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Noah Davis 
ndavis added a comment.


  In D29081#665226 , @cblack wrote:
  
  > In D29081#665203 , @ndavis wrote:
  >
  > > Big +1 to the idea, but this shouldn't use `darker()` because that won't 
look right in Breeze Dark.
  >
  >
  > Personally, I think this will look fine when always using `darker()`.
  
  
  It's not consistent with how breeze dark normally works though.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Carson Black 
cblack added a comment.


  In D29081#665203 , @ndavis wrote:
  
  > Big +1 to the idea, but this shouldn't use `darker()` because that won't 
look right in Breeze Dark.
  
  
  Personally, I think this will look fine when always using `darker()`.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Christoph Feck 
cfeck added a comment.


  Instead of darker, you could use the text color with very small alpha.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Christoph Feck 
cfeck added a comment.


  What a small difference that makes such a large difference!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Nathaniel Graham 
ngraham planned changes to this revision.
ngraham added a comment.


  I messed up the rounded top corner too. Will revise.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Noah Davis 
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Big +1 to the idea, but this shouldn't use `darker()` because that won't look 
right in Breeze Dark.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Niccolò Venerandi 
niccolove accepted this revision as: niccolove.
niccolove added a comment.
This revision is now accepted and ready to land.


  VDG wise, this looks good and consistent.

REPOSITORY
  R31 Breeze

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove
Cc: niccolove, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-04-22 Thread Nathaniel Graham 
ngraham updated this revision to Diff 80924.
ngraham added a comment.


  Make the title look more like Kirigami section separators

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29081?vs=80834=80924

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #vdg, #breeze
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-04-22 Thread Nathaniel Graham 
ngraham added a comment.


  In D29081#654374 , @broulik wrote:
  
  > Not a fan of making it hard to read. I agree that it makes it more obvious 
it's not clickable but we deliberately changed many places that used disabled 
menu items as sections to use proper sections for readability.
  
  
  That's true.
  
  Do you think we should try to mimic the Kirigami ListSectionHeader appearance 
then?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-04-22 Thread Kai Uwe Broulik 
broulik added a comment.


  Not a fan of making it hard to read. I agree that it makes it more obvious 
it's not clickable but we deliberately changed many places that used disabled 
menu items as sections to use proper sections for readability.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

2020-04-21 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The look of Breeze menu titles has always slightly bothered me since they 
have the same
  visual style and weighting as items, so they look clickable even though they 
aren't, and
  they don't really do a very good job of separating sections, as seems to be 
their purpose.
  This patch my my attempt to remedy the situation by making them look more 
"title-like"
  and have greater visual distinctiveness from the items above and below them.

TEST PLAN
  Plasma Task Manager item context menu, before: F8252758: Before.png 

  Plasma Task Manager context menu, after: F8252755: After.png 

  
  KMoreTools menu, before: F8252757: Before, spectacle.png 

  KMoreTools menu, after: F8252756: After, spectacle.png 


REPOSITORY
  R31 Breeze

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #vdg, #breeze
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart