D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-05-01 Thread Filip Fila 
filipf added a comment.


  Yeah we shouldn't be mixing Kirigami with Plasma.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-05-01 Thread Nathaniel Graham 
ngraham added a comment.


  Works for me with a 1x scale factor. Seems like a pre-existing scaling bug.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-05-01 Thread Kai Uwe Broulik 
broulik added a comment.


  This now gives me a tiny icon on the button because this is a //Kirigami// 
component using desktop style:
  F8276714: Screenshot_20200501_221556.png 


REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-04-23 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R97:b75f36807ab4: [applet] Port to Kirigami.PlaceholderMessage 
(authored by ngraham).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29111?vs=80939=80997

REVISION DETAIL
  https://phabricator.kde.org/D29111

AFFECTED FILES
  CMakeLists.txt
  src/applet/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-04-22 Thread Niccolò Venerandi 
niccolove accepted this revision.
niccolove added a comment.
This revision is now accepted and ready to land.


  Yeah, I agree. I see that this behavior is consistent, so I'll accept it.

REPOSITORY
  R97 Bluedevil

BRANCH
  port-to-PlaceholderMessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-04-22 Thread Nathaniel Graham 
ngraham added a comment.


  Well, this is the way we handle focus everywhere in KDE. When you press a 
focusable button, that button gains focus and retains it even after being 
pressed.
  
  IMO the only issue here is the super-obvious-bordering-on-overwhelming way we 
visually show focus, which turns the whole button blue and makes it stand out a 
bit //too//much (IMO).

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-04-22 Thread Niccolò Venerandi 
niccolove added a comment.


  Correct, but shouldn't the focus state stop after button press, or when I 
click away, or at least when I close the applet? Or am I getting the concept of 
focus wrong?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-04-22 Thread Nathaniel Graham 
ngraham added a comment.


  That's the focus state, not the hovered state. If I hit the tab key, focus 
goes somewhere else. Do you see the same?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-04-22 Thread Niccolò Venerandi 
niccolove added a comment.


  It seems like the button never gets out of hovered state:
  F8254176: Screenshot_20200422_231804.png 


REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

2020-04-22 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: VDG, Plasma, drosca, niccolove.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch ports the Bluetooth applet to use `Kirigami.PlaceholderMessage`. 
In the
  process, and as a necessary precondition, it also refactors the code to be 
more
  declarative.

TEST PLAN
  Everything still works perfectly and there are no visual changes aside from 
the message
  having the same margins etc as all the other ones now: F8254152: 
vokoscreenNG-2020-04-22_15-02-49.webm 

REPOSITORY
  R97 Bluedevil

BRANCH
  port-to-PlaceholderMessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29111

AFFECTED FILES
  CMakeLists.txt
  src/applet/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart