D29226: [ksmserver] Use CommandLauncherJob for restoring applications
broulik added a comment. I did, oops, thanks :) https://cgit.kde.org/plasma-workspace.git/commit/?id=eebbf6d47a3e4e31697162eb082c3489aa1f506e REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29226 To: broulik, #plasma, dfaure Cc: jbbgameich, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29226: [ksmserver] Use CommandLauncherJob for restoring applications
jbbgameich added a comment. Did you possibly forget to commit the changes to the header file? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29226 To: broulik, #plasma, dfaure Cc: jbbgameich, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29226: [ksmserver] Use CommandLauncherJob for restoring applications
This revision was automatically updated to reflect the committed changes. Closed by commit R120:963f41e5593c: [ksmserver] Use CommandLauncherJob for restoring applications (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29226?vs=81419&id=81485 REVISION DETAIL https://phabricator.kde.org/D29226 AFFECTED FILES ksmserver/server.cpp To: broulik, #plasma, dfaure Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29226: [ksmserver] Use CommandLauncherJob for restoring applications
broulik updated this revision to Diff 81419. broulik added a comment. - Simplify - Remove pointless return REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29226?vs=81336&id=81419 REVISION DETAIL https://phabricator.kde.org/D29226 AFFECTED FILES ksmserver/server.cpp To: broulik, #plasma, dfaure Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29226: [ksmserver] Use CommandLauncherJob for restoring applications
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > server.cpp:134 > +for ( int i=1; i < n; i++) > + argList.append( command[i]); > +auto *job = new KIO::CommandLauncherJob(app, argList); (pre-existing) argList = command; argList.removeFirst(); would be simpler and faster. > server.cpp:137 > +job->start(); > +return; > } This return statement serves no purpose. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29226 To: broulik, #plasma, dfaure Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29226: [ksmserver] Use CommandLauncherJob for restoring applications
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Rather than calling into `KLauncher` directly. TEST PLAN Compiles, session restore apps are still launched like before REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29226 AFFECTED FILES ksmserver/CMakeLists.txt ksmserver/server.cpp ksmserver/server.h To: broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
