D29297: [Notifications] Have checkIndex check if the index is valid
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f2e34dbbd3b9: [Notifications] Have checkIndex check if the index is valid (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29297?vs=81582=81697 REVISION DETAIL https://phabricator.kde.org/D29297 AFFECTED FILES libnotificationmanager/jobsmodel.cpp libnotificationmanager/notificationsmodel.cpp To: broulik, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29297: [Notifications] Have checkIndex check if the index is valid
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Apparently by default it only considers "out of range" indices invalid but an invalid one as valid. TEST PLAN 5.18? - Closing notifications still works - Pausing, aborting jobs still works Possibly fixes Bug 418347 or some other unexpected crashers? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29297 AFFECTED FILES libnotificationmanager/jobsmodel.cpp libnotificationmanager/notificationsmodel.cpp To: broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
