D29304: Introduce Theme::smallFont

2020-04-30 Thread Carson Black 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9368dcc28f66: Introduce Theme::smallFont (authored by 
cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29304?vs=81603=81604

REVISION DETAIL
  https://phabricator.kde.org/D29304

AFFECTED FILES
  src/controls/Theme.qml
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami, mart
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson

D29304: Introduce Theme::smallFont

2020-04-30 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> basictheme.cpp:74
> +setDefaultFont(qApp->font());
> +setSmallFont([]() {
> +auto smallFont = qApp->font();

you can just do a temp smallfont and then setFont with it without the lambda

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29304

To: cblack, #kirigami
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson

D29304: Introduce Theme::smallFont

2020-04-30 Thread Carson Black 
cblack updated this revision to Diff 81603.
cblack added a comment.


  Drop Rust-ism

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29304?vs=81601=81603

BRANCH
  cblack/smallFont (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29304

AFFECTED FILES
  src/controls/Theme.qml
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29304: Introduce Theme::smallFont

2020-04-30 Thread Carson Black 
cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Like defaultFont, but smaller.

TEST PLAN
  F8273893: font.qml 

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/smallFont (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29304

AFFECTED FILES
  src/controls/Theme.qml
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart