D29319: KCM Plasmasearch: Do not intialize runners in config module
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a07b68a0093c: KCM Plasmasearch: Do not intialize runners in config module (authored by alex). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29319?vs=81692&id=81693 REVISION DETAIL https://phabricator.kde.org/D29319 AFFECTED FILES kcms/runners/kcm.cpp kcms/runners/kcm.h To: alex, #plasma, davidedmundson, ngraham, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29319: KCM Plasmasearch: Do not intialize runners in config module
alex updated this revision to Diff 81692. alex added a comment. Change username from commit And thanks for the fast reviews! REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29319?vs=81645&id=81692 BRANCH arcpatch-D29319 REVISION DETAIL https://phabricator.kde.org/D29319 AFFECTED FILES kcms/runners/kcm.cpp kcms/runners/kcm.h To: alex, #plasma, davidedmundson, ngraham, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29319: KCM Plasmasearch: Do not intialize runners in config module
alex created this revision.
alex added reviewers: Plasma, davidedmundson, ngraham, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.
REVISION SUMMARY
The runners are loaded from the plugin info list
`Plasma::RunnerManager::listRunnerInfo()`,
because of that there is no need to create a RunnerManager and initialize the
plugins.
If you have a lot of additional plugins installed that do a lot of work in
the init/reloadConfiguration
method the loading time of the KCM is notable slower.
Additionally the KCMUTILS_VERSION version check has been removed, because
the KF5_MIN_VERSION is 5.69.
TEST PLAN
All plugin should show up.
To check this create a debug which prints the length of the `listRunnerInfo`
list.
Then you can verify that the length of the list is equal to the count
of entries in the plugin selector. For this you can also use the xdotool
utility:
`sleep 5;for i in {1..myNum}; do sleep 0.1;xdotool key Down; done`.
REPOSITORY
R119 Plasma Desktop
BRANCH
do_not_initialize_runners (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29319
AFFECTED FILES
kcms/runners/kcm.cpp
kcms/runners/kcm.h
To: alex, #plasma, davidedmundson, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
