D29474: Add inHistory bool and hide heading on inHistory

2020-05-06 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7e4b0979: Add inHistory bool and hide heading on 
inHistory (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29474?vs=82066=82128

REVISION DETAIL
  https://phabricator.kde.org/D29474

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29474: Add inHistory bool and hide heading on inHistory

2020-05-06 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a comment.


  I kinda think this should be named more generically, e.g. 
`headerBackgroundVisible`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no_heading_for_ungrouped (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29474

To: niccolove, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29474: Add inHistory bool and hide heading on inHistory

2020-05-06 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Make sure @broulik agrees though

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no_heading_for_ungrouped (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29474

To: niccolove, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29474: Add inHistory bool and hide heading on inHistory

2020-05-06 Thread Niccolò Venerandi
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This hides the plasmoidHeading on history for not grouped notifications

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no_heading_for_ungrouped (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29474

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart